-
Notifications
You must be signed in to change notification settings - Fork 155
8268555: Update HttpClient tests that use ITestContext to jtreg 6+1 #5
Conversation
|
👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into |
|
@dfuch This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit da043e9.
Your commit was automatically rebased without conflicts. |
Another change brought by jtreg 6+1 in the behavior of @BeforeMethod.
Now throwing an exception in @BeforeMethod causes all annotated methods to be skipped, not just those annotated with @test.
HttpClient tests that use @BeforeMethod and ITestContext need to be updated to work around the new behavior.
Rebased to jdk17 repo.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/5/head:pull/5$ git checkout pull/5Update a local copy of the PR:
$ git checkout pull/5$ git pull https://git.openjdk.java.net/jdk17 pull/5/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5View PR using the GUI difftool:
$ git pr show -t 5Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/5.diff