-
Notifications
You must be signed in to change notification settings - Fork 144
8268723: Problem list SA core file tests on OSX when using ZGC #50
Conversation
👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into |
@plummercj To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label serviceability |
@plummercj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks,
David
@plummercj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thumbs up.
I noticed that runtime/ErrorHandling/CreateCoredumpOnCrash.java is |
That test doesn't use ZGC on the spawned process that the core is created for, even when the test is run with -XX:+UseZGC. We've seen it fail in the past only after an OSX 11 host has already been put in a bad state, and refuses to produce a core file successfully for any test, I believe even ones that crash. |
/integrate |
Going to push as commit fe7a44d.
Your commit was automatically rebased without conflicts. |
@plummercj Pushed as commit fe7a44d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
See CR for details. I also relocated AdaptiveBlocking001.java in the list so it is not mixed in with SA tests, and removed serviceability/sa/TestHeapDumpForLargeArray.java since it was moved to the resorucehogs directly long ago, and there is already separate entry that reflects the new location.
Note this is being pushed to JDK17.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/50/head:pull/50
$ git checkout pull/50
Update a local copy of the PR:
$ git checkout pull/50
$ git pull https://git.openjdk.java.net/jdk17 pull/50/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 50
View PR using the GUI difftool:
$ git pr show -t 50
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/50.diff