Skip to content
This repository has been archived by the owner. It is now read-only.

8268723: Problem list SA core file tests on OSX when using ZGC #50

Closed
wants to merge 1 commit into from

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Jun 15, 2021

See CR for details. I also relocated AdaptiveBlocking001.java in the list so it is not mixed in with SA tests, and removed serviceability/sa/TestHeapDumpForLargeArray.java since it was moved to the resorucehogs directly long ago, and there is already separate entry that reflects the new location.

Note this is being pushed to JDK17.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268723: Problem list SA core file tests on OSX when using ZGC

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/50/head:pull/50
$ git checkout pull/50

Update a local copy of the PR:
$ git checkout pull/50
$ git pull https://git.openjdk.java.net/jdk17 pull/50/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 50

View PR using the GUI difftool:
$ git pr show -t 50

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/50.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 15, 2021

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

@plummercj To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@plummercj
Copy link
Contributor Author

@plummercj plummercj commented Jun 15, 2021

/label serviceability

@openjdk openjdk bot added the serviceability label Jun 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

@plummercj
The serviceability label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 15, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

LGTM.

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268723: Problem list SA core file tests on OSX when using ZGC

Reviewed-by: dholmes, dcubed, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 76cad4b: 8263321: Regression 8% in javadoc-steady in 17-b11
  • e36136f: 8268125: ZGC: Clone oop array gets wrong acopy stub
  • 35d867d: 8268663: Crash when guards contain boolean expression
  • 4d8b5c7: 8268347: C2: nested locks optimization may create unbalanced monitor enter/exit code
  • 4a6da99: 8268643: SVML lib shouldn't be generated when C2 is absent
  • a5bf5e0: 8266614: update manpage for -Xlog:async
  • f69e2d5: 8267397: AlgorithmId's OID cache is never refreshed
  • ee30159: 8268621: SunJCE provider may throw unexpected NPE for un-initialized AES KW/KWP Ciphers
  • 702e3ff: 8268366: Incorrect calculation of has_fpu_registers in C1 linear scan
  • bca914b: 8268670: yield statements doesn't allow ~ or ! unary operators in expression

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 15, 2021
Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Thumbs up.

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jun 15, 2021

I noticed that runtime/ErrorHandling/CreateCoredumpOnCrash.java is
not in this list. That's okay, but I think we've seen failures related to that
test also. Is that test going to be handled with a different bug?

@plummercj
Copy link
Contributor Author

@plummercj plummercj commented Jun 15, 2021

I noticed that runtime/ErrorHandling/CreateCoredumpOnCrash.java is
not in this list. That's okay, but I think we've seen failures related to that
test also. Is that test going to be handled with a different bug?

That test doesn't use ZGC on the spawned process that the core is created for, even when the test is run with -XX:+UseZGC. We've seen it fail in the past only after an OSX 11 host has already been put in a bad state, and refuses to produce a core file successfully for any test, I believe even ones that crash.

@plummercj
Copy link
Contributor Author

@plummercj plummercj commented Jun 15, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

Going to push as commit fe7a44d.
Since your change was applied there have been 11 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

@plummercj Pushed as commit fe7a44d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated serviceability
4 participants