Skip to content
This repository has been archived by the owner. It is now read-only.

8268768: idea.sh has been updated in surprising and incompatible ways #61

Closed
wants to merge 2 commits into from

Conversation

mcimadamore
Copy link
Contributor

@mcimadamore mcimadamore commented Jun 15, 2021

As the title says (please also refer to the JBS issue which describes all the issues in more details), the IDE support for IntelliJ has been updated with many enhancements as part of a seemingly innocuous "path handling" fix. The IDE doesn't appear to be usable in the same way it was in the past and many functionalities have been broken as a result (including support for jtreg test execution using the plugin).

For the above reasons, I'm reverting the plugin and idea.sh code to last known working version. Any targeted fix can be re-applied after the revert. Larger enhancements need to be discussed in the proper venue:

https://openjdk.java.net/groups/ide-support/


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268768: idea.sh has been updated in surprising and incompatible ways

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/61/head:pull/61
$ git checkout pull/61

Update a local copy of the PR:
$ git checkout pull/61
$ git pull https://git.openjdk.java.net/jdk17 pull/61/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 61

View PR using the GUI difftool:
$ git pr show -t 61

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/61.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 15, 2021

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

@mcimadamore The following labels will be automatically applied to this pull request:

  • build
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build core-libs labels Jun 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 15, 2021

Webrevs

Copy link
Member

@erikj79 erikj79 left a comment

I think reverting this is fine. In the original review, I tried to point out that it needed to be looked at by people who actually use this functionality, but that never happened.

I wasn't aware of the ide-support mailing list. Would you like me to add automatic filtering in Skara so that changes touching these files are automatically labelled and mailed to that list?

@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268768: idea.sh has been updated in surprising and incompatible ways

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 15, 2021

Mailing list message from Maurizio Cimadamore on build-dev:

On 15/06/2021 17:31, Erik Joelsson wrote:

On Tue, 15 Jun 2021 16:10:01 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

As the title says (please also refer to the JBS issue which describes all the issues in more details), the IDE support for IntelliJ has been updated with many enhancements as part of a seemingly innocuous "path handling" fix. The IDE doesn't appear to be usable in the same way it was in the past and many functionalities have been broken as a result (including support for jtreg test execution using the plugin).

For the above reasons, I'm reverting the plugin and idea.sh code to last known working version. Any targeted fix can be re-applied after the revert. Larger enhancements need to be discussed in the proper venue:

https://openjdk.java.net/groups/ide-support/
I think reverting this is fine. In the original review, I tried to point out that it needed to be looked at by people who actually use this functionality, but that never happened.

I wasn't aware of the ide-support mailing list. Would you like me to add automatic filtering in Skara so that changes touching these files are automatically labelled and mailed to that list?

That would be welcome, yes! Unfortunately cc'ing ide-support using the
PR command doesn't work either, so some changes is needed on the Skara side.

Thanks
Maurizio

1 similar comment
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 15, 2021

Mailing list message from Maurizio Cimadamore on build-dev:

On 15/06/2021 17:31, Erik Joelsson wrote:

On Tue, 15 Jun 2021 16:10:01 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

As the title says (please also refer to the JBS issue which describes all the issues in more details), the IDE support for IntelliJ has been updated with many enhancements as part of a seemingly innocuous "path handling" fix. The IDE doesn't appear to be usable in the same way it was in the past and many functionalities have been broken as a result (including support for jtreg test execution using the plugin).

For the above reasons, I'm reverting the plugin and idea.sh code to last known working version. Any targeted fix can be re-applied after the revert. Larger enhancements need to be discussed in the proper venue:

https://openjdk.java.net/groups/ide-support/
I think reverting this is fine. In the original review, I tried to point out that it needed to be looked at by people who actually use this functionality, but that never happened.

I wasn't aware of the ide-support mailing list. Would you like me to add automatic filtering in Skara so that changes touching these files are automatically labelled and mailed to that list?

That would be welcome, yes! Unfortunately cc'ing ide-support using the
PR command doesn't work either, so some changes is needed on the Skara side.

Thanks
Maurizio

@erikj79
Copy link
Member

@erikj79 erikj79 commented Jun 15, 2021

Exactly, I need to add the label and the mailing list config.

@erikj79
Copy link
Member

@erikj79 erikj79 commented Jun 15, 2021

Making the change here openjdk/skara#1189

@erikj79
Copy link
Member

@erikj79 erikj79 commented Jun 15, 2021

/label ide-support

@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

@erikj79 The label ide-support is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • sound
  • hotspot-compiler
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • 2d
  • security
  • swing
  • hotspot-runtime
  • jmx
  • build
  • nio
  • beans
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr
  • awt

@erikj79
Copy link
Member

@erikj79 erikj79 commented Jun 15, 2021

/label ide-support

@openjdk openjdk bot added the ide-support label Jun 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

@erikj79
The ide-support label was successfully added.

@erikj79
Copy link
Member

@erikj79 erikj79 commented Jun 15, 2021

This comment should now end up in ide-support-dev as well.

@mcimadamore
Copy link
Contributor Author

@mcimadamore mcimadamore commented Jun 15, 2021

This comment should now end up in ide-support-dev as well.

Not really (at least for now) :-)

@erikj79
Copy link
Member

@erikj79 erikj79 commented Jun 15, 2021

It got stuck in moderation. Tim has fixed the config now, so this message should hopefully appear.

@mcimadamore
Copy link
Contributor Author

@mcimadamore mcimadamore commented Jun 15, 2021

It got stuck in moderation. Tim has fixed the config now, so this message should hopefully appear.

Yep - I see emails now. Thanks this is really useful!

@mcimadamore
Copy link
Contributor Author

@mcimadamore mcimadamore commented Jun 15, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

Going to push as commit 788b309.
Since your change was applied there have been 16 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

@mcimadamore Pushed as commit 788b309.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build core-libs ide-support integrated
2 participants