Skip to content
This repository has been archived by the owner. It is now read-only.

8268828: ProblemList compiler/intrinsics/VectorizedMismatchTest.java on win-x64 #64

Closed
wants to merge 1 commit into from
Closed

Conversation

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jun 15, 2021

A trivial fix to ProblemList compiler/intrinsics/VectorizedMismatchTest.java on win-x64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268828: ProblemList compiler/intrinsics/VectorizedMismatchTest.java on win-x64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/64/head:pull/64
$ git checkout pull/64

Update a local copy of the PR:
$ git checkout pull/64
$ git pull https://git.openjdk.java.net/jdk17 pull/64/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 64

View PR using the GUI difftool:
$ git pr show -t 64

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/64.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 15, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Jun 15, 2021

/label add hotspot-compiler
/label add hotspot-runtime

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Jun 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

@dcubed-ojdk
The hotspot-compiler label was successfully added.

@openjdk openjdk bot added the rfr label Jun 15, 2021
Copy link
Member

@calvinccheung calvinccheung left a comment

Looks good and trivial.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268828: ProblemList compiler/intrinsics/VectorizedMismatchTest.java on win-x64

Reviewed-by: ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Jun 15, 2021

@calvinccheung - Thanks for the fast review!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

Going to push as commit 9ac0609.

@openjdk openjdk bot closed this Jun 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

@dcubed-ojdk Pushed as commit 9ac0609.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 15, 2021

Webrevs

@dcubed-ojdk dcubed-ojdk deleted the JDK-8268828 branch Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants