Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

8268676: assert(!ik->is_interface() && !ik->has_subklass()) failed: inconsistent klass hierarchy #67

Closed

Conversation

iwanowww
Copy link

@iwanowww iwanowww commented Jun 15, 2021

JDK-8267947 disabled the caching for "has_subklass() == false" and it became
more likely to observe class hierarchy changes when concurrent class loading
happens.

ArrayCopy optimization may observe an effectively exact klass and proceed,
but the observation can be invalidated later.

Proposed fix turns the problematic assert into a runtime check which bails out
the transformation if src input doesn't have exact klass type anymore.

Testing:

  • hs-tier1 - hs-tier2

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268676: assert(!ik->is_interface() && !ik->has_subklass()) failed: inconsistent klass hierarchy

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/67/head:pull/67
$ git checkout pull/67

Update a local copy of the PR:
$ git checkout pull/67
$ git pull https://git.openjdk.java.net/jdk17 pull/67/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 67

View PR using the GUI difftool:
$ git pr show -t 67

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/67.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 15, 2021

👋 Welcome back vlivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@iwanowww
Copy link
Author

/label add hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.java.net label Jun 15, 2021
@openjdk
Copy link

openjdk bot commented Jun 15, 2021

@iwanowww
The hotspot-compiler label was successfully added.

@iwanowww iwanowww marked this pull request as ready for review June 15, 2021 22:00
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 15, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 15, 2021

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@openjdk
Copy link

openjdk bot commented Jun 15, 2021

@iwanowww This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268676: assert(!ik->is_interface() && !ik->has_subklass()) failed: inconsistent klass hierarchy

Reviewed-by: kvn, roland, neliasso

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 4d545a1: 8267988: C2: assert(!addp->is_AddP() || addp->in(AddPNode::Base)->is_top() || addp->in(AddPNode::Base) == n->in(AddPNode::Base)) failed: Base pointers must match (addp 1301)
  • b18de6c: 8268851: ProblemList jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java on linux-X64
  • 10068c1: 8268830: ProblemList 3 serviceability/dcmd/framework tests with ZGC on win-x64
  • 788b309: 8268768: idea.sh has been updated in surprising and incompatible ways
  • 9ac0609: 8268828: ProblemList compiler/intrinsics/VectorizedMismatchTest.java on win-x64
  • fe7a44d: 8268723: Problem list SA core file tests on OSX when using ZGC
  • 31a055e: 8268736: Use apiNote in AutoCloseable.close javadoc
  • 76cad4b: 8263321: Regression 8% in javadoc-steady in 17-b11
  • e36136f: 8268125: ZGC: Clone oop array gets wrong acopy stub

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 15, 2021
Copy link
Contributor

@rwestrel rwestrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link

@neliasso neliasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@iwanowww
Copy link
Author

Thanks for the reviews, Vladimir, Roland, and Nils.

/integrate

@openjdk
Copy link

openjdk bot commented Jun 17, 2021

Going to push as commit 8545269.
Since your change was applied there have been 29 commits pushed to the master branch:

  • c98d508: 8268265: MutableSpaceUsedHelper::take_sample() hits assert(left >= right) failed: avoid overflow
  • b66001a: 8268971: ProblemList tools/jpackage/windows/WinInstallerIconTest.java on win-x64
  • 0011b52: 8264843: Javac crashes with NullPointerException when finding unencoded XML in
     tag
  • 2047da7: 8265297: javax/net/ssl/SSLSession/TestEnabledProtocols.java failed with "RuntimeException: java.net.SocketException: Connection reset"
  • 091bc4a: 8268353: Test libsvml.so is and is not present in jdk image
  • 69d01b6: 8249899: jdk/javadoc/tool/InlineTagsWithBraces.java uses @ignore w/o bug-id
  • 7d7bdbe: 8268776: Test ADatagramSocket.java missing /othervm from @run tag
  • 344e3ed: 8268080: java/util/concurrent/forkjoin/AsyncShutdownNow.java fails with java.util.concurrent.RejectedExecutionException
  • 4c9aefd: 8268739: AArch64: Build failure after JDK-8267663
  • 112ddb7: 8268641: [foreign] assert(allocates2(pc)) failed: not in CodeBuffer memory with ShenandoahGC
  • ... and 19 more: https://git.openjdk.java.net/jdk17/compare/35d867df1f2064e867dcf1030c498bfa23568054...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 17, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 17, 2021
@openjdk
Copy link

openjdk bot commented Jun 17, 2021

@iwanowww Pushed as commit 8545269.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.java.net integrated Pull request has been integrated
4 participants