-
Notifications
You must be signed in to change notification settings - Fork 144
8268563: mark hotspot serviceability/jvmti tests which ignore external VM flags #7
Conversation
👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into |
@iignatev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Serguei, thank you for your review. /integrate |
Going to push as commit 5b19898.
Your commit was automatically rebased without conflicts. |
Hi all,
could you please review this one-liner that adds
@requires vm.flagless
to 6serviceability/jvmti
tests that ignore external VM flags?Thanks,
-- Igor
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/7/head:pull/7
$ git checkout pull/7
Update a local copy of the PR:
$ git checkout pull/7
$ git pull https://git.openjdk.java.net/jdk17 pull/7/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7
View PR using the GUI difftool:
$ git pr show -t 7
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/7.diff