Skip to content
This repository has been archived by the owner. It is now read-only.

8268861: Disable Windows-Aarch64 build in GitHub Actions #71

Closed
wants to merge 3 commits into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Jun 16, 2021

This has been failing for a while so disabling it until it can be fixed.

Thanks,
David


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268861: Disable Windows-Aarch64 build in GitHub Actions

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/71/head:pull/71
$ git checkout pull/71

Update a local copy of the PR:
$ git checkout pull/71
$ git pull https://git.openjdk.java.net/jdk17 pull/71/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 71

View PR using the GUI difftool:
$ git pr show -t 71

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/71.diff

@dholmes-ora dholmes-ora marked this pull request as ready for review Jun 16, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 16, 2021

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 16, 2021

@dholmes-ora The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build label Jun 16, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 16, 2021

Webrevs

vidmik
vidmik approved these changes Jun 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 16, 2021

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268861: Disable Windows-Aarch64 build in GitHub Actions

Reviewed-by: mikael, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 59de99d: 8267271: Fix gc/arguments/TestNewRatioFlag.java expectedNewSize calculation
  • 4d545a1: 8267988: C2: assert(!addp->is_AddP() || addp->in(AddPNode::Base)->is_top() || addp->in(AddPNode::Base) == n->in(AddPNode::Base)) failed: Base pointers must match (addp 1301)
  • b18de6c: 8268851: ProblemList jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java on linux-X64
  • 10068c1: 8268830: ProblemList 3 serviceability/dcmd/framework tests with ZGC on win-x64
  • 788b309: 8268768: idea.sh has been updated in surprising and incompatible ways
  • 9ac0609: 8268828: ProblemList compiler/intrinsics/VectorizedMismatchTest.java on win-x64
  • fe7a44d: 8268723: Problem list SA core file tests on OSX when using ZGC
  • 31a055e: 8268736: Use apiNote in AutoCloseable.close javadoc
  • 76cad4b: 8263321: Regression 8% in javadoc-steady in 17-b11
  • e36136f: 8268125: ZGC: Clone oop array gets wrong acopy stub
  • ... and 3 more: https://git.openjdk.java.net/jdk17/compare/a5bf5e0e5f6c18b51e398ab81ed9d0a29bf31b6f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 16, 2021
Copy link
Contributor

@kstefanj kstefanj left a comment

Thanks for fixing this, looks good!

@dholmes-ora
Copy link
Member Author

@dholmes-ora dholmes-ora commented Jun 16, 2021

/integrate

Thanks for the reviews.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 16, 2021

Going to push as commit 19f5fab.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 59de99d: 8267271: Fix gc/arguments/TestNewRatioFlag.java expectedNewSize calculation
  • 4d545a1: 8267988: C2: assert(!addp->is_AddP() || addp->in(AddPNode::Base)->is_top() || addp->in(AddPNode::Base) == n->in(AddPNode::Base)) failed: Base pointers must match (addp 1301)
  • b18de6c: 8268851: ProblemList jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java on linux-X64
  • 10068c1: 8268830: ProblemList 3 serviceability/dcmd/framework tests with ZGC on win-x64
  • 788b309: 8268768: idea.sh has been updated in surprising and incompatible ways
  • 9ac0609: 8268828: ProblemList compiler/intrinsics/VectorizedMismatchTest.java on win-x64
  • fe7a44d: 8268723: Problem list SA core file tests on OSX when using ZGC
  • 31a055e: 8268736: Use apiNote in AutoCloseable.close javadoc
  • 76cad4b: 8263321: Regression 8% in javadoc-steady in 17-b11
  • e36136f: 8268125: ZGC: Clone oop array gets wrong acopy stub
  • ... and 3 more: https://git.openjdk.java.net/jdk17/compare/a5bf5e0e5f6c18b51e398ab81ed9d0a29bf31b6f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 16, 2021

@dholmes-ora Pushed as commit 19f5fab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8268861 branch Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build integrated
3 participants