Skip to content
This repository has been archived by the owner. It is now read-only.

8268776: Test ADatagramSocket.java missing /othervm from @run tag #75

Closed
wants to merge 1 commit into from

Conversation

@pconcannon
Copy link
Contributor

@pconcannon pconcannon commented Jun 16, 2021

Hi,

Could someone please review my change to the test test/jdk/java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.java? The test is missing /othervm from its @run jtreg test tag, which risks polluting other tests that run in that VM.

Currently, any test that runs without /othervm after this test would find the DatagramSocketImpl factory created by this test, and therefore any call made to new DatagramSocket() would return/use a NetMulticastSocket instead of DatagramSocketAdaptor. This could make tests that create DatagramSocket/MulticastSocket fail intermittently in unexplainable ways. Adding in /othervm to the @run tag will avoid this problem.

Kind regards,
Patrick


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/75/head:pull/75
$ git checkout pull/75

Update a local copy of the PR:
$ git checkout pull/75
$ git pull https://git.openjdk.java.net/jdk17 pull/75/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 75

View PR using the GUI difftool:
$ git pr show -t 75

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/75.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 16, 2021

👋 Welcome back pconcannon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

dfuch
dfuch approved these changes Jun 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 16, 2021

@pconcannon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268776: Test `ADatagramSocket.java` missing /othervm from @run tag

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 16, 2021

@pconcannon The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the net label Jun 16, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 16, 2021

Webrevs

Loading

@pconcannon
Copy link
Contributor Author

@pconcannon pconcannon commented Jun 17, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 17, 2021

Going to push as commit 7d7bdbe.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 344e3ed: 8268080: java/util/concurrent/forkjoin/AsyncShutdownNow.java fails with java.util.concurrent.RejectedExecutionException
  • 4c9aefd: 8268739: AArch64: Build failure after JDK-8267663
  • 112ddb7: 8268641: [foreign] assert(allocates2(pc)) failed: not in CodeBuffer memory with ShenandoahGC
  • 9f7851b: 8260194: Update the documentation for -Xcheck:jni
  • ee03bc6: 8268863: ProblemList serviceability/sa/TestJmapCoreMetaspace.java on linux-x64 with ZGC
  • f0f2178: 8268909: ProblemList jdk/jfr/api/consumer/streaming/TestLatestEvent.java on win-x64
  • 54f5ffe: 8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java test
  • 2c7e47e: 8268774: Residual logging output written to STDOUT, not STDERR
  • 8ea0606: 8268714: [macos-aarch64] 7 java/net/httpclient/websocket tests failed
  • 38dbe05: 8268901: JDK-8268768 missed removing two files
  • ... and 2 more: https://git.openjdk.java.net/jdk17/compare/59de99d11988b7f1ab20e323f3dc4d0d49e3b7a3...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jun 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 17, 2021

@pconcannon Pushed as commit 7d7bdbe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants