Skip to content
This repository has been archived by the owner. It is now read-only.

8268564: mark hotspot serviceability/attach tests which ignore external VM flags #8

Closed
wants to merge 1 commit into from

Conversation

iignatev
Copy link
Member

@iignatev iignatev commented Jun 10, 2021

Hi all,

could you please review this one-liner that adds @requires vm.flagless to 2 serviceability/attach tests that ignore external VM flags?

Thanks,
-- Igor


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268564: mark hotspot serviceability/attach tests which ignore external VM flags

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/8/head:pull/8
$ git checkout pull/8

Update a local copy of the PR:
$ git checkout pull/8
$ git pull https://git.openjdk.java.net/jdk17 pull/8/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8

View PR using the GUI difftool:
$ git pr show -t 8

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/8.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 10, 2021

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8268564 8268564: mark hotspot serviceability/attach tests which ignore external VM flags Jun 10, 2021
@openjdk openjdk bot added the rfr label Jun 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@iignatev The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability label Jun 10, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 10, 2021

Webrevs

@plummercj
Copy link
Contributor

@plummercj plummercj commented Jun 10, 2021

Can you explain a bit more how @requires vm.flagless works? The way I read it, that would indicate that the test should not be run if any flags are specified. I'm not sure why you would want to do that. I understand that the test itself launches a subprocess without passing on the flags, but I don't see why that would preclude running the test if any flags are specified.

@iignatev
Copy link
Member Author

@iignatev iignatev commented Jun 11, 2021

Can you explain a bit more how @requires vm.flagless works? The way I read it, that would indicate that the test should not be run if any flags are specified. I'm not sure why you would want to do that. I understand that the test itself launches a subprocess without passing on the flags, but I don't see why that would preclude running the test if any flags are specified.

Hi Chris,

sure, you have read it correctly -- @requires vm.flagless excludes a test from execution if "any" flags are specified. there are two main reasons to do that: a) a test is very sensitive to the testing configuration and nearly any changes to the configuration render the test invalid; b) a test ignores all external flags, hence running it w/ any is a waste and misleading. in the case of this patch (as well as other sub-tasks of 8246500), it's the latter.

you can read more about vm.flagless and the motivation in the main-main bug and/or the original discussion on hotspot-dev.

Cheers,
-- Igor

@openjdk
Copy link

@openjdk openjdk bot commented Jun 11, 2021

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268564: mark hotspot serviceability/attach tests which ignore external VM flags

Reviewed-by: sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 01054e6: 8268470: CDS dynamic dump asserts with JFR RecordingStream
  • e39346e: 8268093: Manual Testcase: "sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE
  • cce8da2: 8268602: a couple runtime/os tests don't check exit code
  • da043e9: 8268555: Update HttpClient tests that use ITestContext to jtreg 6+1
  • a437ce8: 8268580: runtime/memory/LargePages/TestLargePagesFlags.java should be run in driver mode
  • bd9c2fa: 8268565: runtime/records/RedefineRecord.java should be run in driver mode
  • e3eef3b: 8268576: jdk/jfr/event/gc/collection/TestSystemGc.java fails
  • 7b2e7d8: 8268525: Some new memory leak after JDK-8248268 and JDK-8255557
  • 53b6e2c: 8267448: Add "ulimit -a" to environment.html

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 11, 2021
@iignatev
Copy link
Member Author

@iignatev iignatev commented Jun 18, 2021

Thank you, Serguei.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

Going to push as commit 21abcc4.
Since your change was applied there have been 66 commits pushed to the master branch:

  • f83c6b8: 8268531: mark SDTProbesGNULinuxTest as ignoring external VM flags
  • 8366c69: 8268541: mark hotspot serviceability/sa tests which ignore external VM flags
  • 5b19898: 8268563: mark hotspot serviceability/jvmti tests which ignore external VM flags
  • 2f65d40: 8268599: mark hotspot runtime/sealedClasses tests which ignore external VM flags
  • 3e1dc0a: 8268598: mark hotspot runtime/stringtable tests which ignore external VM flags
  • 58eddc8: 8268594: runtime/handshake tests don't need WhiteBox after AOT removal
  • 9f4f039: 8268596: mark hotspot runtime/verifier tests which ignore external VM flags
  • 4006fe7: 8268597: mark hotspot runtime/symboltable tests which ignore external VM flags
  • 8ccb76e: 8268601: mark hotspot runtime/records tests which ignore external VM flags
  • 59d8478: 8268591: a few runtime/jni tests don't need /othervm
  • ... and 56 more: https://git.openjdk.java.net/jdk17/compare/5b8c51f59a5f23930ee43bea30201c1ff88c44cd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

@iignatev Pushed as commit 21abcc4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated serviceability
3 participants