Skip to content
This repository has been archived by the owner. It is now read-only.

8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java test #83

Closed
wants to merge 1 commit into from

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Jun 16, 2021

clean backport to JDK 17.

Reviewed-by: xuelei


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java test

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/83/head:pull/83
$ git checkout pull/83

Update a local copy of the PR:
$ git checkout pull/83
$ git pull https://git.openjdk.java.net/jdk17 pull/83/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 83

View PR using the GUI difftool:
$ git pr show -t 83

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/83.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 16, 2021

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b836b83b2aefbc87b0cf26990ddbab4479c42b71 8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java test Jun 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 16, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 16, 2021

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java test

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jun 16, 2021
@rhalade
Copy link
Member Author

@rhalade rhalade commented Jun 16, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 16, 2021

@rhalade The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Jun 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 16, 2021

Going to push as commit 54f5ffe.

@openjdk openjdk bot closed this Jun 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 16, 2021

@rhalade Pushed as commit 54f5ffe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rhalade rhalade deleted the 8259338 branch Jun 16, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 16, 2021

Webrevs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated security
1 participant