-
Notifications
You must be signed in to change notification settings - Fork 143
8268470: CDS dynamic dump asserts with JFR RecordingStream #9
Conversation
/label add hotspot-runtime |
👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into |
@calvinccheung |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@calvinccheung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Going to push as commit 01054e6.
Your commit was automatically rebased without conflicts. |
@calvinccheung Pushed as commit 01054e6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
During JFR startup, it redefines some of the builtin classes like
java/lang/Throwable
. Later, when a subclass of Throwable is loaded, it will inherit the redefined version of Throwable which will not be inside the buffer space or mapped static archive.To fix this bug, in
SystemDictionaryShared::check_for_exclusion_impl()
, instead of only checking if the class has been redefined, it also checks if any of its super types has been redefined. If so, exclude the class from the archive.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/9/head:pull/9
$ git checkout pull/9
Update a local copy of the PR:
$ git checkout pull/9
$ git pull https://git.openjdk.java.net/jdk17 pull/9/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9
View PR using the GUI difftool:
$ git pr show -t 9
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/9.diff