Skip to content
This repository has been archived by the owner. It is now read-only.

8268470: CDS dynamic dump asserts with JFR RecordingStream #9

Closed

Conversation

@calvinccheung
Copy link
Member

@calvinccheung calvinccheung commented Jun 10, 2021

During JFR startup, it redefines some of the builtin classes like java/lang/Throwable. Later, when a subclass of Throwable is loaded, it will inherit the redefined version of Throwable which will not be inside the buffer space or mapped static archive.

To fix this bug, in SystemDictionaryShared::check_for_exclusion_impl(), instead of only checking if the class has been redefined, it also checks if any of its super types has been redefined. If so, exclude the class from the archive.

  • mach5 tier1, tier2 (including the new test) (in progress)

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268470: CDS dynamic dump asserts with JFR RecordingStream

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/9/head:pull/9
$ git checkout pull/9

Update a local copy of the PR:
$ git checkout pull/9
$ git pull https://git.openjdk.java.net/jdk17 pull/9/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9

View PR using the GUI difftool:
$ git pr show -t 9

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/9.diff

@calvinccheung
Copy link
Member Author

@calvinccheung calvinccheung commented Jun 10, 2021

/label add hotspot-runtime

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 10, 2021

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@calvinccheung
The hotspot-runtime label was successfully added.

Loading

@calvinccheung calvinccheung marked this pull request as ready for review Jun 10, 2021
@openjdk openjdk bot added the rfr label Jun 10, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 10, 2021

Webrevs

Loading

yminqi
yminqi approved these changes Jun 10, 2021
Copy link
Contributor

@yminqi yminqi left a comment

LGTM.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268470: CDS dynamic dump asserts with JFR RecordingStream

Reviewed-by: minqi, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • e39346e: 8268093: Manual Testcase: "sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE
  • cce8da2: 8268602: a couple runtime/os tests don't check exit code
  • da043e9: 8268555: Update HttpClient tests that use ITestContext to jtreg 6+1
  • a437ce8: 8268580: runtime/memory/LargePages/TestLargePagesFlags.java should be run in driver mode
  • bd9c2fa: 8268565: runtime/records/RedefineRecord.java should be run in driver mode
  • e3eef3b: 8268576: jdk/jfr/event/gc/collection/TestSystemGc.java fails
  • 7b2e7d8: 8268525: Some new memory leak after JDK-8248268 and JDK-8255557
  • 53b6e2c: 8267448: Add "ulimit -a" to environment.html

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jun 10, 2021
iklam
iklam approved these changes Jun 11, 2021
Copy link
Member

@iklam iklam left a comment

LGTM

Loading

@calvinccheung
Copy link
Member Author

@calvinccheung calvinccheung commented Jun 11, 2021

@yminqi, @iklam Thanks for the review!
/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 11, 2021

Going to push as commit 01054e6.
Since your change was applied there have been 8 commits pushed to the master branch:

  • e39346e: 8268093: Manual Testcase: "sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE
  • cce8da2: 8268602: a couple runtime/os tests don't check exit code
  • da043e9: 8268555: Update HttpClient tests that use ITestContext to jtreg 6+1
  • a437ce8: 8268580: runtime/memory/LargePages/TestLargePagesFlags.java should be run in driver mode
  • bd9c2fa: 8268565: runtime/records/RedefineRecord.java should be run in driver mode
  • e3eef3b: 8268576: jdk/jfr/event/gc/collection/TestSystemGc.java fails
  • 7b2e7d8: 8268525: Some new memory leak after JDK-8248268 and JDK-8255557
  • 53b6e2c: 8267448: Add "ulimit -a" to environment.html

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jun 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 11, 2021

@calvinccheung Pushed as commit 01054e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@calvinccheung calvinccheung deleted the 8268470-jfr-dyn-dump branch Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants