Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

8268971: ProblemList tools/jpackage/windows/WinInstallerIconTest.java on win-x64 #90

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jun 17, 2021

A trivial fix to ProblemList tools/jpackage/windows/WinInstallerIconTest.java on win-x64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268971: ProblemList tools/jpackage/windows/WinInstallerIconTest.java on win-x64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/90/head:pull/90
$ git checkout pull/90

Update a local copy of the PR:
$ git checkout pull/90
$ git pull https://git.openjdk.java.net/jdk17 pull/90/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 90

View PR using the GUI difftool:
$ git pr show -t 90

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/90.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add tools

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.java.net label Jun 17, 2021
@openjdk
Copy link

openjdk bot commented Jun 17, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk
Copy link

openjdk bot commented Jun 17, 2021

@dcubed-ojdk The label tools is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • sound
  • hotspot-compiler
  • ide-support
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • 2d
  • swing
  • hotspot-runtime
  • jmx
  • nio
  • build
  • beans
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr
  • awt

@dcubed-ojdk
Copy link
Member Author

/label add core-libs

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review June 17, 2021 16:38
@openjdk openjdk bot added rfr Pull request is ready for review core-libs core-libs-dev@openjdk.java.net labels Jun 17, 2021
@openjdk
Copy link

openjdk bot commented Jun 17, 2021

@dcubed-ojdk
The core-libs label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jun 17, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 17, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268971: ProblemList tools/jpackage/windows/WinInstallerIconTest.java on win-x64

Reviewed-by: herrick

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 0011b52: 8264843: Javac crashes with NullPointerException when finding unencoded XML in
     tag

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 17, 2021
@dcubed-ojdk
Copy link
Member Author

@andyherrick - Thanks for the fast review!

/integrate

@openjdk
Copy link

openjdk bot commented Jun 17, 2021

Going to push as commit b66001a.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 0011b52: 8264843: Javac crashes with NullPointerException when finding unencoded XML in
     tag

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 17, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 17, 2021
@openjdk
Copy link

openjdk bot commented Jun 17, 2021

@dcubed-ojdk Pushed as commit b66001a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8268971 branch June 17, 2021 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core-libs core-libs-dev@openjdk.java.net hotspot-runtime hotspot-runtime-dev@openjdk.java.net integrated Pull request has been integrated
2 participants