8275170: Some jtreg sound tests should be marked with sound keyword

Backport-of: 25669bb667466b3cc814f8f08d4e3a2982a4cf2e
openjdk · Sep 28, 2022 · 36f0116
1 parent 7c2b227
commit 36f0116
Show file tree

Hide file tree

Showing 58 changed files with 63 additions and 4 deletions.
diff --git a/test/jdk/TEST.ROOT b/test/jdk/TEST.ROOT
@@ -11,11 +11,15 @@
 #
 # A "headful" test requires a graphical environment to meaningfully
 # run. Tests that are not headful are "headless".
+# A test flagged with key sound needs audio devices on the system, this
+# may be accompanied by the headful keyword since audio device access 
+# is often linked to access to desktop resources and headful systems are
+# also more likely to have audio devices (ie meaning both input and output)
 # A test flagged with key "printer" requires a printer to succeed, else
 # throws a PrinterException or the like.
 # A test flagged with cgroups uses cgroups.
 
-keys=2d dnd headful i18n intermittent printer randomness jfr cgroups
+keys=2d dnd headful sound i18n intermittent printer randomness jfr cgroups
 
 # Tests that must run in othervm mode
 othervm.dirs=java/awt java/beans javax/accessibility javax/imageio javax/sound javax/swing javax/print \

diff --git a/test/jdk/javax/sound/midi/Devices/ClosedReceiver.java b/test/jdk/javax/sound/midi/Devices/ClosedReceiver.java
@@ -32,6 +32,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 4616517
  * @summary Receiver.send() does not work properly
  */

diff --git a/test/jdk/javax/sound/midi/Devices/InitializationHang.java b/test/jdk/javax/sound/midi/Devices/InitializationHang.java
@@ -28,6 +28,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 8068412
  */
 public final class InitializationHang {

diff --git a/test/jdk/javax/sound/midi/Devices/MidiDeviceGetReceivers.java b/test/jdk/javax/sound/midi/Devices/MidiDeviceGetReceivers.java
@@ -31,6 +31,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 4931387
  * @summary Add methods to MidiDevice to get list of Transmitters and Receivers
  */

diff --git a/test/jdk/javax/sound/midi/Devices/MidiIO.java b/test/jdk/javax/sound/midi/Devices/MidiIO.java
@@ -27,6 +27,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 4356787
  * @summary MIDI device I/O is not working
  */

diff --git a/test/jdk/javax/sound/midi/Devices/MidiOutGetMicrosecondPositionBug.java b/test/jdk/javax/sound/midi/Devices/MidiOutGetMicrosecondPositionBug.java
@@ -28,6 +28,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 4903786
  * @summary MIDI OUT does not implement getMicrosecondPosition() consistently
  */

diff --git a/test/jdk/javax/sound/midi/Devices/OpenClose.java b/test/jdk/javax/sound/midi/Devices/OpenClose.java
@@ -31,6 +31,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 4616517
  * @summary Receiver.send() does not work properly. Tests open/close behaviour
  *          of MidiDevices. For this test, it is essential that the MidiDevice

diff --git a/test/jdk/javax/sound/midi/Devices/ReceiverTransmitterAvailable.java b/test/jdk/javax/sound/midi/Devices/ReceiverTransmitterAvailable.java
@@ -29,6 +29,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 4616517
  * @summary Receiver.send() does not work properly
  */

diff --git a/test/jdk/javax/sound/midi/Devices/Reopen.java b/test/jdk/javax/sound/midi/Devices/Reopen.java
@@ -28,6 +28,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 4914667
  * @summary Closing and reopening MIDI IN device on Linux throws
  *          MidiUnavailableException

diff --git a/test/jdk/javax/sound/midi/MidiSystem/DefaultDevices.java b/test/jdk/javax/sound/midi/MidiSystem/DefaultDevices.java
@@ -39,6 +39,7 @@
  * @bug 4776511
  * @bug 4934509
  * @bug 4938236
+ * @key sound
  * @modules java.desktop/com.sun.media.sound
  * @run main/timeout=600 DefaultDevices
  * @summary RFE: Setting the default MixerProvider

diff --git a/test/jdk/javax/sound/midi/MidiSystem/GetSequencer.java b/test/jdk/javax/sound/midi/MidiSystem/GetSequencer.java
@@ -30,6 +30,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 4931400
  * @summary Clarify default connections in default sequencer
  */

diff --git a/test/jdk/javax/sound/midi/Sequence/GetMicrosecondLength.java b/test/jdk/javax/sound/midi/Sequence/GetMicrosecondLength.java
@@ -30,6 +30,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 4929955
  * @summary Sequence.getMicrosecondLength() returns wrong value
  */

diff --git a/test/jdk/javax/sound/midi/Sequencer/LoopIAE.java b/test/jdk/javax/sound/midi/Sequencer/LoopIAE.java
@@ -32,6 +32,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 5025549
  * @summary Verify that setLoopEndPoint throws IAE
  */

diff --git a/test/jdk/javax/sound/midi/Sequencer/MetaCallback.java b/test/jdk/javax/sound/midi/Sequencer/MetaCallback.java
@@ -36,7 +36,7 @@
  * @test
  * @bug 4347135
  * @summary MIDI MetaMessage callback inconsistent
- * @key intermittent
+ * @key intermittent sound
  * @run main/othervm MetaCallback
  */
 public class MetaCallback implements MetaEventListener {

diff --git a/test/jdk/javax/sound/midi/Sequencer/Recording.java b/test/jdk/javax/sound/midi/Sequencer/Recording.java
@@ -34,7 +34,7 @@
 /**
  * @test
  * @bug 4932841
- * @key intermittent
+ * @key intermittent sound
  * @summary Sequencer's recording feature does not work
  */
 public class Recording {

diff --git a/test/jdk/javax/sound/midi/Sequencer/SeqRecordDoesNotCopy.java b/test/jdk/javax/sound/midi/Sequencer/SeqRecordDoesNotCopy.java
@@ -33,6 +33,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 5048381
  * @summary Sequencer doesn't create distinct messages when recording events.
  */

diff --git a/test/jdk/javax/sound/midi/Sequencer/SeqRecordsRealTimeEvents.java b/test/jdk/javax/sound/midi/Sequencer/SeqRecordsRealTimeEvents.java
@@ -33,6 +33,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 5048381
  * @summary Sequencer records real time messages into the sequence
  */

diff --git a/test/jdk/javax/sound/midi/Sequencer/SeqStartRecording.java b/test/jdk/javax/sound/midi/Sequencer/SeqStartRecording.java
@@ -27,6 +27,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 5001943
  * @summary Sequencer.startRecording throws unexpected NPE
  */

diff --git a/test/jdk/javax/sound/midi/Sequencer/SequencerCacheValues.java b/test/jdk/javax/sound/midi/Sequencer/SequencerCacheValues.java
@@ -28,6 +28,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 4716740
  * @summary default sequencer does not set the tempo factor
  */

diff --git a/test/jdk/javax/sound/midi/Sequencer/SequencerImplicitSynthOpen.java b/test/jdk/javax/sound/midi/Sequencer/SequencerImplicitSynthOpen.java
@@ -23,6 +23,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 6660470
  * @summary Tests that sequencer correctly opens/closes (implicitly) devices
  * @author Alex Menkov

diff --git a/test/jdk/javax/sound/midi/Sequencer/SequencerSetMuteSolo.java b/test/jdk/javax/sound/midi/Sequencer/SequencerSetMuteSolo.java
@@ -33,6 +33,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 4713900
  * @summary default Sequencer allows to set Mute for invalid track
  */

diff --git a/test/jdk/javax/sound/midi/Sequencer/SequencerState.java b/test/jdk/javax/sound/midi/Sequencer/SequencerState.java
@@ -34,6 +34,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 4913027
  * @summary several Sequencer methods should specify behaviour on closed Sequencer
  */

diff --git a/test/jdk/javax/sound/midi/Sequencer/SetTickPosition.java b/test/jdk/javax/sound/midi/Sequencer/SetTickPosition.java
@@ -30,8 +30,9 @@
 
 /**
  * @test
+ * @key sound
  * @bug 4493775
- * @summary Sequncer method, setTickPosition(long) doesnot set the Tick position
+ * @summary Sequencer method, setTickPosition(long) does not set the Tick position
  */
 public class SetTickPosition {
         private static boolean testPassed = true;

diff --git a/test/jdk/javax/sound/midi/Sequencer/TickLength.java b/test/jdk/javax/sound/midi/Sequencer/TickLength.java
@@ -33,6 +33,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 4427890
  * @run main/othervm TickLength
  * @summary Sequencer.getTickLength() and Sequence.getTickLength() report the

diff --git a/test/jdk/javax/sound/midi/Soundbanks/ExtraCharInSoundbank.java b/test/jdk/javax/sound/midi/Soundbanks/ExtraCharInSoundbank.java
@@ -30,6 +30,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 4429762
  * @summary Some instrument names in some soundbanks include bad extra characters
  */

diff --git a/test/jdk/javax/sound/sampled/AudioSystem/DefaultMixers.java b/test/jdk/javax/sound/sampled/AudioSystem/DefaultMixers.java
@@ -38,6 +38,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 4776511
  * @summary RFE: Setting the default MixerProvider. Test the retrieving of lines
  *          with defaut mixer properties.

diff --git a/test/jdk/javax/sound/sampled/Clip/ClipCloseLoss.java b/test/jdk/javax/sound/sampled/Clip/ClipCloseLoss.java
@@ -33,6 +33,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 4946913 8178403
  * @summary DirectClip doesn't kill the thread correctly, sometimes
  * @run main/othervm ClipCloseLoss

diff --git a/test/jdk/javax/sound/sampled/Clip/ClipFlushCrash.java b/test/jdk/javax/sound/sampled/Clip/ClipFlushCrash.java
@@ -33,6 +33,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 4946945
  * @summary Crash in javasound while running TicTacToe demo applet tiger b26
  */

diff --git a/test/jdk/javax/sound/sampled/Clip/Drain/ClipDrain.java b/test/jdk/javax/sound/sampled/Clip/Drain/ClipDrain.java
@@ -29,6 +29,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 4732218
  * @summary Clip.drain does not actually block until all I/O is complete as
  *          documented.

diff --git a/test/jdk/javax/sound/sampled/Clip/Duration/ClipDuration.java b/test/jdk/javax/sound/sampled/Clip/Duration/ClipDuration.java
@@ -33,6 +33,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 4237703
  * @summary Check that Clip.getMicrosecondLength() returns correct value.
  */

diff --git a/test/jdk/javax/sound/sampled/Clip/Endpoint/ClipSetEndPoint.java b/test/jdk/javax/sound/sampled/Clip/Endpoint/ClipSetEndPoint.java
@@ -33,6 +33,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 4385928
  * @summary Verify that an endpoint -1 in Clip does not throw an exception
  */

diff --git a/test/jdk/javax/sound/sampled/Controls/FloatControl/FloatControlBug.java b/test/jdk/javax/sound/sampled/Controls/FloatControl/FloatControlBug.java
@@ -34,6 +34,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 4385654
  * @summary Check that the MASTER_GAIN control has a valid precision
  */

diff --git a/test/jdk/javax/sound/sampled/DataLine/DataLineInfoNegBufferSize.java b/test/jdk/javax/sound/sampled/DataLine/DataLineInfoNegBufferSize.java
@@ -30,6 +30,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 5021234
  * @summary Using -2 for buffer size will fail retrieval of lines
  */

diff --git a/test/jdk/javax/sound/sampled/DataLine/DataLine_ArrayIndexOutOfBounds.java b/test/jdk/javax/sound/sampled/DataLine/DataLine_ArrayIndexOutOfBounds.java
@@ -23,6 +23,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 7088367
  * @summary SourceDataLine.write and TargetDataLine.read don't throw ArrayIndexOutOfBoundsException
  * @author Alex Menkov

diff --git a/test/jdk/javax/sound/sampled/DataLine/LineDefFormat.java b/test/jdk/javax/sound/sampled/DataLine/LineDefFormat.java
@@ -31,6 +31,7 @@
 
 /**
  * @test
+ * @key sound
  * @bug 5053380
  * @summary Verify that getting a line initializes it with the format in
  *          DataLine.Info

diff --git a/test/jdk/javax/sound/sampled/Lines/16and32KHz/Has16and32KHz.java b/test/jdk/javax/sound/sampled/Lines/16and32KHz/Has16and32KHz.java
@@ -32,6 +32,7 @@
 
 /**
  * @test
+ * @key sound