Skip to content

Commit

Permalink
8278893: Parallel: Remove GCWorkerDelayMillis
Browse files Browse the repository at this point in the history
Backport-of: ff5d41762d5ba31e88c6cb9207a8ae57f34a69b0
  • Loading branch information
reinrich committed Mar 6, 2024
1 parent dbf4a99 commit 5421bb6
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 21 deletions.
3 changes: 0 additions & 3 deletions src/hotspot/share/gc/parallel/parallel_globals.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,6 @@
"limiter (a number between 0-100)") \
range(0, 100) \
\
develop(uintx, GCWorkerDelayMillis, 0, \
"Delay in scheduling GC workers (in milliseconds)") \
\
product(bool, PSChunkLargeArrays, true, \
"Process large arrays in chunks")

Expand Down
11 changes: 0 additions & 11 deletions src/hotspot/share/gc/parallel/psCardTable.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,6 @@ void PSCardTable::scavenge_contents_parallel(ObjectStartArray* start_array,
uint stripe_number,
uint stripe_total) {
int ssize = 128; // Naked constant! Work unit = 64k.
int dirty_card_count = 0;

// It is a waste to get here if empty.
assert(sp->bottom() < sp->top(), "Should not be called if empty");
Expand Down Expand Up @@ -195,16 +194,6 @@ void PSCardTable::scavenge_contents_parallel(ObjectStartArray* start_array,
HeapWord* slice_start = addr_for(worker_start_card);
HeapWord* slice_end = MIN2((HeapWord*) sp_top, addr_for(worker_end_card));

#ifdef ASSERT
if (GCWorkerDelayMillis > 0) {
// Delay 1 worker so that it proceeds after all the work
// has been completed.
if (stripe_number < 2) {
os::naked_sleep(GCWorkerDelayMillis);
}
}
#endif

// If there are not objects starting within the chunk, skip it.
if (!start_array->object_starts_in_range(slice_start, slice_end)) {
continue;
Expand Down
7 changes: 0 additions & 7 deletions src/hotspot/share/gc/parallel/psPromotionManager.inline.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -218,13 +218,6 @@ inline oop PSPromotionManager::copy_unmarked_to_survivor_space(oop o,

HeapWord* lab_base = old_gen()->allocate(OldPLABSize);
if(lab_base != NULL) {
#ifdef ASSERT
// Delay the initialization of the promotion lab (plab).
// This exposes uninitialized plabs to card table processing.
if (GCWorkerDelayMillis > 0) {
os::naked_sleep(GCWorkerDelayMillis);
}
#endif
_old_lab.initialize(MemRegion(lab_base, OldPLABSize));
// Try the old lab allocation again.
new_obj = cast_to_oop(_old_lab.allocate(new_obj_size));
Expand Down

1 comment on commit 5421bb6

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.