Permalink
Show file tree
Hide file tree
1 comment
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
8273972: Multi-core choke point in CMM engine (LCMSTransform.doTransf…
…orm) Backport-of: e49e5b5a7ed9e493380fb73100057898c707b31b
- Loading branch information
Showing
5 changed files
with
333 additions
and
41 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,146 @@ | ||
| /* | ||
| * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved. | ||
| * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| * | ||
| * This code is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU General Public License version 2 only, as | ||
| * published by the Free Software Foundation. | ||
| * | ||
| * This code is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| * version 2 for more details (a copy is included in the LICENSE file that | ||
| * accompanied this code). | ||
| * | ||
| * You should have received a copy of the GNU General Public License version | ||
| * 2 along with this work; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * | ||
| * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
| * or visit www.oracle.com if you need additional information or have any | ||
| * questions. | ||
| */ | ||
|
|
||
| import java.awt.color.ColorSpace; | ||
| import java.awt.image.BufferedImage; | ||
| import java.awt.image.ColorConvertOp; | ||
|
|
||
| /** | ||
| * @test | ||
| * @bug 8273972 | ||
| * @summary Verifies that ColorConvertOp works fine if shared between threads | ||
| * @run main/othervm/timeout=600 MTTransformValidation | ||
| */ | ||
| public final class MTPerLineTransformValidation { | ||
|
|
||
| private volatile static BufferedImage[] lines; | ||
|
|
||
| public static final int SIZE = 255; | ||
| private static volatile boolean failed = false; | ||
|
|
||
| private static final int[] spaces = { | ||
| ColorSpace.CS_CIEXYZ, ColorSpace.CS_GRAY, ColorSpace.CS_LINEAR_RGB, | ||
| ColorSpace.CS_PYCC, ColorSpace.CS_sRGB | ||
| }; | ||
|
|
||
| private static final int[] types = new int[]{ | ||
| BufferedImage.TYPE_INT_RGB, BufferedImage.TYPE_INT_ARGB, | ||
| BufferedImage.TYPE_INT_ARGB_PRE, BufferedImage.TYPE_INT_BGR, | ||
| BufferedImage.TYPE_3BYTE_BGR, BufferedImage.TYPE_4BYTE_ABGR, | ||
| BufferedImage.TYPE_4BYTE_ABGR_PRE, | ||
| BufferedImage.TYPE_USHORT_565_RGB, | ||
| BufferedImage.TYPE_USHORT_555_RGB, BufferedImage.TYPE_BYTE_GRAY, | ||
| BufferedImage.TYPE_USHORT_GRAY, BufferedImage.TYPE_BYTE_BINARY, | ||
| BufferedImage.TYPE_BYTE_INDEXED | ||
| }; | ||
|
|
||
| /** | ||
| * For all possible combinations of color spaces and image types, convert | ||
| * the source image using one shared ColorConvertOp per line on the | ||
| * different threads. The result is validated against images converted on | ||
| * one thread only. | ||
| */ | ||
| public static void main(String[] args) throws Exception { | ||
| for (int srcCS : spaces) { | ||
| for (int dstCS : spaces) { | ||
| if(srcCS != dstCS) { | ||
| for (int type : types) { | ||
| checkTypes(ColorSpace.getInstance(srcCS), | ||
| ColorSpace.getInstance(dstCS), type); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private static void checkTypes(ColorSpace srcCS, ColorSpace dstCS, int type) | ||
| throws Exception { | ||
| lines = new BufferedImage[SIZE]; | ||
| ColorConvertOp goldOp = new ColorConvertOp(srcCS, dstCS, null); | ||
| BufferedImage src = createSrc(type); | ||
| BufferedImage gold = goldOp.filter(src, null); | ||
|
|
||
| // we do not share the goldOp since it is already initialized and used | ||
| // for the whole image, instead we will create a separate sharedOp and | ||
| // use it for each line of a different threads | ||
| ColorConvertOp sharedOp = new ColorConvertOp(srcCS, dstCS, null); | ||
| Thread[] threads = new Thread[SIZE]; | ||
| for (int y = 0; y < SIZE; ++y) { | ||
| BufferedImage line = src.getSubimage(0, y, SIZE, 1); | ||
| threads[y] = test(sharedOp, line, y); | ||
| } | ||
|
|
||
| for (Thread t: threads) { | ||
| t.start(); | ||
| } | ||
| for (Thread t: threads) { | ||
| t.join(); | ||
| } | ||
| for (int y = 0; y < SIZE; ++y) { | ||
| validate(gold, lines[y], y); | ||
| } | ||
| if (failed) { | ||
| throw new RuntimeException("Unexpected exception"); | ||
| } | ||
| } | ||
|
|
||
| private static Thread test(ColorConvertOp sharedOp, | ||
| BufferedImage line, int y){ | ||
| return new Thread(() -> { | ||
| try { | ||
| BufferedImage image = sharedOp.filter(line, null); | ||
| lines[y] = image; | ||
| } catch (Throwable t) { | ||
| t.printStackTrace(); | ||
| failed = true; | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| private static BufferedImage createSrc(int type) { | ||
| BufferedImage img = new BufferedImage(SIZE, SIZE, type); | ||
| fill(img); | ||
| return img; | ||
| } | ||
|
|
||
| private static void fill(BufferedImage image) { | ||
| for (int i = 0; i < SIZE; i++) { | ||
| for (int j = 0; j < SIZE; j++) { | ||
| image.setRGB(i, j, | ||
| (i << 24) | (i << 16) | (j << 8) | ((i + j) >> 1)); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private static void validate(BufferedImage full, BufferedImage line, int y) { | ||
| for (int i = 0; i < SIZE; i++) { | ||
| int rgb1 = full.getRGB(i, y); | ||
| int rgb2 = line.getRGB(i, 0); | ||
| if (rgb1 != rgb2) { | ||
| System.err.println("rgb1 = " + Integer.toHexString(rgb1)); | ||
| System.err.println("rgb2 = " + Integer.toHexString(rgb2)); | ||
| throw new RuntimeException(); | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
55fb592There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review
Issues