Skip to content

Commit cfe714b

Browse files
committed
8325194: GHA: Add macOS M1 testing
8325444: GHA: JDK-8325194 causes a regression 8309934: Update GitHub Actions to use JDK 17 for building jtreg Reviewed-by: mbaesken Backport-of: d1c82156ba6ede4b798ac15f935289cfcc99d1a0
1 parent 05bea0e commit cfe714b

File tree

4 files changed

+37
-13
lines changed

4 files changed

+37
-13
lines changed

.github/actions/get-jtreg/action.yml

+8-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#
2-
# Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
2+
# Copyright (c) 2023, 2024, Oracle and/or its affiliates. All rights reserved.
33
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
#
55
# This code is free software; you can redistribute it and/or modify it
@@ -56,8 +56,14 @@ runs:
5656

5757
- name: 'Build JTReg'
5858
run: |
59+
# If runner architecture is x64 set JAVA_HOME_17_X64 otherwise set to JAVA_HOME_17_arm64
60+
if [[ '${{ runner.arch }}' == 'X64' ]]; then
61+
JDK="$JAVA_HOME_17_X64"
62+
else
63+
JDK="$JAVA_HOME_17_arm64"
64+
fi
5965
# Build JTReg and move files to the proper locations
60-
bash make/build.sh --jdk "$JAVA_HOME_11_X64"
66+
bash make/build.sh --jdk "$JDK"
6167
mkdir ../installed
6268
mv build/images/jtreg/* ../installed
6369
working-directory: jtreg/src

.github/workflows/build-macos.yml

+7-4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#
2-
# Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
2+
# Copyright (c) 2022, 2024, Oracle and/or its affiliates. All rights reserved.
33
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
#
55
# This code is free software; you can redistribute it and/or modify it
@@ -31,6 +31,9 @@ on:
3131
platform:
3232
required: true
3333
type: string
34+
runs-on:
35+
required: true
36+
type: string
3437
extra-conf-options:
3538
required: false
3639
type: string
@@ -55,7 +58,7 @@ on:
5558
jobs:
5659
build-macos:
5760
name: build
58-
runs-on: macos-13
61+
runs-on: ${{ inputs.runs-on }}
5962

6063
strategy:
6164
fail-fast: false
@@ -74,7 +77,7 @@ jobs:
7477
id: bootjdk
7578
uses: ./.github/actions/get-bootjdk
7679
with:
77-
platform: macos-x64
80+
platform: ${{ inputs.platform }}
7881

7982
- name: 'Get JTReg'
8083
id: jtreg
@@ -87,7 +90,7 @@ jobs:
8790
- name: 'Install toolchain and dependencies'
8891
run: |
8992
# Run Homebrew installation and xcode-select
90-
brew install make
93+
brew install autoconf make
9194
sudo xcode-select --switch /Applications/Xcode_${{ inputs.xcode-toolset-version }}.app/Contents/Developer
9295
# This will make GNU make available as 'make' and not only as 'gmake'
9396
echo '/usr/local/opt/make/libexec/gnubin' >> $GITHUB_PATH

.github/workflows/main.yml

+13-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#
2-
# Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
2+
# Copyright (c) 2022, 2024, Oracle and/or its affiliates. All rights reserved.
33
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
#
55
# This code is free software; you can redistribute it and/or modify it
@@ -223,6 +223,7 @@ jobs:
223223
uses: ./.github/workflows/build-macos.yml
224224
with:
225225
platform: macos-x64
226+
runs-on: 'macos-13'
226227
xcode-toolset-version: '14.3.1'
227228
configure-arguments: ${{ github.event.inputs.configure-arguments }}
228229
make-arguments: ${{ github.event.inputs.make-arguments }}
@@ -234,8 +235,8 @@ jobs:
234235
uses: ./.github/workflows/build-macos.yml
235236
with:
236237
platform: macos-aarch64
238+
runs-on: 'macos-14'
237239
xcode-toolset-version: '14.3.1'
238-
extra-conf-options: '--openjdk-target=aarch64-apple-darwin'
239240
configure-arguments: ${{ github.event.inputs.configure-arguments }}
240241
make-arguments: ${{ github.event.inputs.make-arguments }}
241242
if: needs.select.outputs.macos-aarch64 == 'true'
@@ -300,6 +301,16 @@ jobs:
300301
bootjdk-platform: macos-x64
301302
runs-on: macos-13
302303

304+
test-macos-aarch64:
305+
name: macos-aarch64
306+
needs:
307+
- build-macos-aarch64
308+
uses: ./.github/workflows/test.yml
309+
with:
310+
platform: macos-aarch64
311+
bootjdk-platform: macos-aarch64
312+
runs-on: macos-14
313+
303314
test-windows-x64:
304315
name: windows-x64
305316
needs:

make/conf/github-actions.conf

+9-5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#
2-
# Copyright (c) 2020, 2023, Oracle and/or its affiliates. All rights reserved.
2+
# Copyright (c) 2020, 2024, Oracle and/or its affiliates. All rights reserved.
33
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
#
55
# This code is free software; you can redistribute it and/or modify it
@@ -32,10 +32,14 @@ LINUX_X64_BOOT_JDK_EXT=tar.gz
3232
LINUX_X64_BOOT_JDK_URL=https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.11%2B9/OpenJDK17U-jdk_x64_linux_hotspot_17.0.11_9.tar.gz
3333
LINUX_X64_BOOT_JDK_SHA256=aa7fb6bb342319d227a838af5c363bfa1b4a670c209372f9e6585bd79da6220c
3434

35-
WINDOWS_X64_BOOT_JDK_EXT=zip
36-
WINDOWS_X64_BOOT_JDK_URL=https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.11%2B9/OpenJDK17U-jdk_x64_windows_hotspot_17.0.11_9.zip
37-
WINDOWS_X64_BOOT_JDK_SHA256=fdd6664d4131370398fbc8bfbb7b46dbfec4a22a090a511fe5c379dae188c390
38-
3935
MACOS_X64_BOOT_JDK_EXT=tar.gz
4036
MACOS_X64_BOOT_JDK_URL=https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.11%2B9/OpenJDK17U-jdk_x64_mac_hotspot_17.0.11_9.tar.gz
4137
MACOS_X64_BOOT_JDK_SHA256=f8b96724618f4df557c47f11048d1084e98ed3eb87f0dbd5b84f768a80c3348e
38+
39+
MACOS_AARCH64_BOOT_JDK_EXT=tar.gz
40+
MACOS_AARCH64_BOOT_JDK_URL=https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.11%2B9/OpenJDK17U-jdk_aarch64_mac_hotspot_17.0.11_9.tar.gz
41+
MACOS_AARCH64_BOOT_JDK_SHA256=09a162c58dd801f7cfacd87e99703ed11fb439adc71cfa14ceb2d3194eaca01c
42+
43+
WINDOWS_X64_BOOT_JDK_EXT=zip
44+
WINDOWS_X64_BOOT_JDK_URL=https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.11%2B9/OpenJDK17U-jdk_x64_windows_hotspot_17.0.11_9.zip
45+
WINDOWS_X64_BOOT_JDK_SHA256=fdd6664d4131370398fbc8bfbb7b46dbfec4a22a090a511fe5c379dae188c390

0 commit comments

Comments
 (0)