Skip to content

Commit

Permalink
8282600: SSLSocketImpl should not use user_canceled workaround when n…
Browse files Browse the repository at this point in the history
…ot necessary

Backport-of: 7e88ff8a82cefa2a20acc9d5a9e42858d60fe3a3
  • Loading branch information
zzambers authored and GoeLin committed Nov 2, 2022
1 parent e609398 commit eef3c96
Showing 1 changed file with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -639,8 +639,12 @@ private void duplexCloseOutput() throws IOException {
if (!conContext.protocolVersion.useTLS13PlusSpec()) {
hasCloseReceipt = true;
} else {
// Use a user_canceled alert for TLS 1.3 duplex close.
useUserCanceled = true;
// Do not use user_canceled workaround if the other side has
// already half-closed the connection
if (!conContext.isInboundClosed()) {
// Use a user_canceled alert for TLS 1.3 duplex close.
useUserCanceled = true;
}
}
} else if (conContext.handshakeContext != null) { // initial handshake
// Use user_canceled alert regardless the protocol versions.
Expand Down

3 comments on commit eef3c96

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zzambers
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on eef3c96 Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zzambers the backport was successfully created on the branch zzambers-backport-eef3c960 in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit eef3c960 from the openjdk/jdk17u-dev repository.

The commit being backported was authored by Zdenek Zambersky on 2 Nov 2022 and had no reviewers.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev zzambers-backport-eef3c960:zzambers-backport-eef3c960
$ git checkout zzambers-backport-eef3c960
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev zzambers-backport-eef3c960

Please sign in to comment.