Skip to content

Commit

Permalink
8275643: C2's unaryOp vector intrinsic does not properly handle LongV…
Browse files Browse the repository at this point in the history
…ector.neg

Backport-of: 47564caeb0628e5c03a0e7f04093adce77d6dd3b
  • Loading branch information
GoeLin committed Feb 3, 2022
1 parent 27cbe24 commit f723588
Show file tree
Hide file tree
Showing 2 changed files with 51 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/hotspot/share/prims/vectorSupport.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,7 @@ int VectorSupport::vop2ideal(jint id, BasicType bt) {
case T_BYTE: // fall-through
case T_SHORT: // fall-through
case T_INT: return Op_NegI;
case T_LONG: return Op_NegL;
case T_FLOAT: return Op_NegF;
case T_DOUBLE: return Op_NegD;
default: fatal("NEG: %s", type2name(bt));
Expand Down
50 changes: 50 additions & 0 deletions test/hotspot/jtreg/compiler/vectorapi/TestLongVectorNeg.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
/*
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

package compiler.vectorapi;

import jdk.incubator.vector.LongVector;

/*
* @test
* @bug 8275643
* @summary Test that LongVector.neg is properly handled by the _VectorUnaryOp C2 intrinsic
* @modules jdk.incubator.vector
* @run main/othervm -XX:-TieredCompilation -XX:+AlwaysIncrementalInline -Xbatch
* -XX:CompileCommand=dontinline,compiler.vectorapi.TestLongVectorNeg::test
* compiler.vectorapi.TestLongVectorNeg
*/
public class TestLongVectorNeg {

static LongVector test(LongVector v) {
return v.neg();
}

public static void main(String[] args) {
LongVector v = LongVector.zero(LongVector.SPECIES_128);
for (int i = 0; i < 50_000; ++i) {
v.abs(); // Warmup to make sure the !VO_SPECIAL code path is taken as well
test(v);
}
}
}

1 comment on commit f723588

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.