-
Notifications
You must be signed in to change notification settings - Fork 208
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
8277137: Set OnSpinWaitInst/OnSpinWaitInstCount defaults to "isb"/1 f…
…or Arm Neoverse N1 Backport-of: 38345bd28db83371676f1685806ddc207a833879
- Loading branch information
Showing
2 changed files
with
105 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97 changes: 97 additions & 0 deletions
97
test/hotspot/jtreg/compiler/onSpinWait/TestOnSpinWaitAArch64DefaultFlags.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,97 @@ | ||
/* | ||
* Copyright Amazon.com Inc. or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
|
||
/** | ||
* @test TestOnSpinWaitAArch64DefaultFlags | ||
* @summary Check default values of '-XX:OnSpinWaitInst' and '-XX:OnSpinWaitInstCount' for AArch64 implementations. | ||
* @bug 8277137 | ||
* @library /test/lib / | ||
* | ||
* @requires os.arch=="aarch64" | ||
* | ||
* @build sun.hotspot.WhiteBox | ||
* @run driver jdk.test.lib.helpers.ClassFileInstaller sun.hotspot.WhiteBox | ||
* @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions | ||
* -XX:+WhiteBoxAPI | ||
* compiler.onSpinWait.TestOnSpinWaitAArch64DefaultFlags | ||
*/ | ||
|
||
package compiler.onSpinWait; | ||
|
||
import java.util.Iterator; | ||
import java.util.List; | ||
import jdk.test.lib.process.OutputAnalyzer; | ||
import jdk.test.lib.process.ProcessTools; | ||
import sun.hotspot.cpuinfo.CPUInfo; | ||
|
||
public class TestOnSpinWaitAArch64DefaultFlags { | ||
private static boolean isCPUModelNeoverseN1(String cpuModel) { | ||
return cpuModel.contains("0xd0c"); | ||
} | ||
|
||
private static void checkFinalFlagsEqualTo(ProcessBuilder pb, String expectedOnSpinWaitInstValue, String expectedOnSpinWaitInstCountValue) throws Exception { | ||
OutputAnalyzer analyzer = new OutputAnalyzer(pb.start()); | ||
analyzer.shouldHaveExitValue(0); | ||
|
||
Iterator<String> iter = analyzer.asLines().listIterator(); | ||
String line = null; | ||
boolean hasExpectedOnSpinWaitInstValue = false; | ||
boolean hasExpectedOnSpinWaitInstCountValue = false; | ||
while (iter.hasNext()) { | ||
line = iter.next(); | ||
if (!hasExpectedOnSpinWaitInstValue && line.contains("ccstr OnSpinWaitInst")) { | ||
hasExpectedOnSpinWaitInstValue = line.contains("= " + expectedOnSpinWaitInstValue); | ||
} | ||
|
||
if (!hasExpectedOnSpinWaitInstCountValue && line.contains("uint OnSpinWaitInstCount")) { | ||
hasExpectedOnSpinWaitInstCountValue = line.contains("= " + expectedOnSpinWaitInstCountValue); | ||
} | ||
} | ||
if (!hasExpectedOnSpinWaitInstValue) { | ||
System.out.println(analyzer.getOutput()); | ||
throw new RuntimeException("OnSpinWaitInst with the expected value '" + expectedOnSpinWaitInstValue + "' not found."); | ||
} | ||
if (!hasExpectedOnSpinWaitInstCountValue) { | ||
System.out.println(analyzer.getOutput()); | ||
throw new RuntimeException("OnSpinWaitInstCount with the expected value '" + expectedOnSpinWaitInstCountValue + "' not found."); | ||
} | ||
} | ||
|
||
public static void main(String[] args) throws Exception { | ||
List<String> cpuFeatures = CPUInfo.getFeatures(); | ||
if (cpuFeatures.isEmpty()) { | ||
System.out.println("Skip because no CPU features are available."); | ||
return; | ||
} | ||
|
||
final String cpuModel = cpuFeatures.get(0); | ||
|
||
if (isCPUModelNeoverseN1(cpuModel)) { | ||
checkFinalFlagsEqualTo(ProcessTools.createJavaProcessBuilder("-XX:+PrintFlagsFinal", "-version"), "isb", "1"); | ||
checkFinalFlagsEqualTo(ProcessTools.createJavaProcessBuilder("-XX:+UnlockDiagnosticVMOptions", "-XX:OnSpinWaitInstCount=2", "-XX:+PrintFlagsFinal", "-version"), | ||
"isb", "2"); | ||
} else { | ||
System.out.println("Skip because no defaults for CPU model: " + cpuModel); | ||
} | ||
} | ||
} |
fe1d8e9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review
Issues