Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278822: Bump update version for OpenJDK: jdk-17.0.3 #1

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 17, 2021

The necessary version bump for 17.0.3

Also configure jcheck to automatically set the JBS version.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278822: Bump update version for OpenJDK: jdk-17.0.3

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/1/head:pull/1
$ git checkout pull/1

Update a local copy of the PR:
$ git checkout pull/1
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/1/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1

View PR using the GUI difftool:
$ git pr show -t 1

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/1.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 17, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 17, 2021

⚠️ @GoeLin a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master aa11a935373686bf5d67afb89368931c995824f6
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk openjdk bot added the rfr label Dec 17, 2021
@openjdk
Copy link

openjdk bot commented Dec 17, 2021

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278822: Bump update version for OpenJDK: jdk-17.0.3

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 17, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 17, 2021

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Dec 17, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Dec 17, 2021

Going to push as commit 2e9b271.

@openjdk openjdk bot added the integrated label Dec 17, 2021
@openjdk openjdk bot closed this Dec 17, 2021
@openjdk openjdk bot removed ready rfr labels Dec 17, 2021
@openjdk
Copy link

openjdk bot commented Dec 17, 2021

@GoeLin Pushed as commit 2e9b271.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

gnu-andrew pushed a commit to gnu-andrew/jdk17u-dev that referenced this issue Jun 6, 2022
RH2023467: Enable FIPS keys export

Co-Authored-By: Martin Balao <mbalao@redhat.com>
Co-Authored-By: Alex Kashchenko <akashche@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
2 participants