Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295066: Folding of loads is broken in C2 after JDK-8242115 #1001

Closed
wants to merge 5 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 29, 2022

I backport this for parity with 17.0.7-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295066: Folding of loads is broken in C2 after JDK-8242115

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1001/head:pull/1001
$ git checkout pull/1001

Update a local copy of the PR:
$ git checkout pull/1001
$ git pull https://git.openjdk.org/jdk17u-dev pull/1001/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1001

View PR using the GUI difftool:
$ git pr show -t 1001

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1001.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 29, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@GoeLin GoeLin changed the base branch from master to pr/999 December 29, 2022 17:56
@GoeLin GoeLin changed the title Goetz backport 8295066 Backport 58a7141a0dea5d1b4bfe6d56a95d860c854b3461 Dec 29, 2022
@openjdk openjdk bot changed the title Backport 58a7141a0dea5d1b4bfe6d56a95d860c854b3461 8295066: Folding of loads is broken in C2 after JDK-8242115 Dec 29, 2022
@openjdk
Copy link

openjdk bot commented Dec 29, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 29, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 29, 2022

Webrevs

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/999 to master January 2, 2023 20:29
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8295066
git fetch https://git.openjdk.org/jdk17u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean label Jan 2, 2023
@openjdk openjdk bot added the clean label Jan 2, 2023
@openjdk
Copy link

openjdk bot commented Jan 2, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295066: Folding of loads is broken in C2 after JDK-8242115

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 2, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Jan 2, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 2, 2023

Going to push as commit 0ac93eb.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 2, 2023
@openjdk openjdk bot closed this Jan 2, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 2, 2023
@openjdk
Copy link

openjdk bot commented Jan 2, 2023

@GoeLin Pushed as commit 0ac93eb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8295066 branch January 2, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant