-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8292177: InitialSecurityProperty JFR event #1004
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout goetz_backport_8292177
git fetch https://git.openjdk.org/jdk17u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM;
probably the related release note should mention 17.0.X after this gets pushed.
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 95f23f7.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 17.0.7-oracle.
I resolved the following code:
src/java.base/share/classes/module-info.java
Trivial resolve.
src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java
Resolved imports.
test/lib/jdk/test/lib/jfr/EventNames.java
Does not match because,
for example, later change 8295419: JFR: Change name of jdk.JitRestart was already backported.
This was tedious to resolve, because the larger part of the
change is a cleanup exchanging "final static" by "static final".
Besides that I spotted the addition of a single new
line for "InitialSecurityProperty".
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1004/head:pull/1004
$ git checkout pull/1004
Update a local copy of the PR:
$ git checkout pull/1004
$ git pull https://git.openjdk.org/jdk17u-dev pull/1004/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1004
View PR using the GUI difftool:
$ git pr show -t 1004
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1004.diff