Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296136: Use correct register in aarch64_enc_fast_unlock() #1005

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 30, 2022

I backport this for parity with 17.0.7-oracle.

Omitted riskv part. Will mark as clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296136: Use correct register in aarch64_enc_fast_unlock()

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1005/head:pull/1005
$ git checkout pull/1005

Update a local copy of the PR:
$ git checkout pull/1005
$ git pull https://git.openjdk.org/jdk17u-dev pull/1005/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1005

View PR using the GUI difftool:
$ git pr show -t 1005

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1005.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 30, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7619602c365acee73a490f05be2bd0d3dd09d7a4 8296136: Use correct register in aarch64_enc_fast_unlock() Dec 30, 2022
@openjdk
Copy link

openjdk bot commented Dec 30, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 30, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 30, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Dec 31, 2022

/clean

@openjdk openjdk bot added the clean label Dec 31, 2022
@openjdk
Copy link

openjdk bot commented Dec 31, 2022

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Dec 31, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296136: Use correct register in aarch64_enc_fast_unlock()

Reviewed-by: rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • aa8a841: 8290964: C2 compilation fails with assert "non-reduction loop contains reduction nodes"
  • 61e27b4: 8292780: misc tests failed "assert(false) failed: graph should be schedulable"
  • 43668f9: 8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop
  • 330105c: 8292602: ZGC: C2 late barrier analysis uses invalid dominator information
  • 4be52ee: 8292297: Fix up loading of override java.security properties file
  • 475ca04: 8281122: [IR Framework] Cleanup IR matching code in preparation for JDK-8280378
  • d667e32: 8280889: java/lang/instrument/GetObjectSizeIntrinsicsTest.java fails with -XX:-UseCompressedOops
  • 587d5c5: 8280166: Extend java/lang/instrument/GetObjectSizeIntrinsicsTest.java test cases
  • 410fa44: 8258512: serviceability/sa/TestJmapCore.java timed out on macOS 10.13.6
  • eb76fa3: 8270156: Add "randomness" and "stress" keys to JTreg tests which use StressGCM, StressLCM and/or StressIGVN
  • ... and 3 more: https://git.openjdk.org/jdk17u-dev/compare/633a763b3793f4f83cea2c3990f35c6b081582fd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 31, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Jan 2, 2023

/integrate

@GoeLin
Copy link
Member Author

GoeLin commented Jan 2, 2023

Thanks for reviewing!

@openjdk
Copy link

openjdk bot commented Jan 2, 2023

Going to push as commit 9a2743f.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 7be0b5a: 8293531: C2: some vectorapi tests fail assert "Not monotonic" with flag -XX:TypeProfileLevel=222
  • aa8a841: 8290964: C2 compilation fails with assert "non-reduction loop contains reduction nodes"
  • 61e27b4: 8292780: misc tests failed "assert(false) failed: graph should be schedulable"
  • 43668f9: 8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop
  • 330105c: 8292602: ZGC: C2 late barrier analysis uses invalid dominator information
  • 4be52ee: 8292297: Fix up loading of override java.security properties file
  • 475ca04: 8281122: [IR Framework] Cleanup IR matching code in preparation for JDK-8280378
  • d667e32: 8280889: java/lang/instrument/GetObjectSizeIntrinsicsTest.java fails with -XX:-UseCompressedOops
  • 587d5c5: 8280166: Extend java/lang/instrument/GetObjectSizeIntrinsicsTest.java test cases
  • 410fa44: 8258512: serviceability/sa/TestJmapCore.java timed out on macOS 10.13.6
  • ... and 4 more: https://git.openjdk.org/jdk17u-dev/compare/633a763b3793f4f83cea2c3990f35c6b081582fd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 2, 2023
@openjdk openjdk bot closed this Jan 2, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 2, 2023
@openjdk
Copy link

openjdk bot commented Jan 2, 2023

@GoeLin Pushed as commit 9a2743f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8296136 branch January 2, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants