Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280132: Incorrect comparator com.sun.beans.introspect.MethodInfo.MethodOrder #1014

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Dec 31, 2022

Hi all,
This pull request contains a backport of commit 2f46af05 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 9 Feb 2022 and was reviewed by Phil Race.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8280132: Incorrect comparator com.sun.beans.introspect.MethodInfo.MethodOrder

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1014/head:pull/1014
$ git checkout pull/1014

Update a local copy of the PR:
$ git checkout pull/1014
$ git pull https://git.openjdk.org/jdk17u-dev pull/1014/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1014

View PR using the GUI difftool:
$ git pr show -t 1014

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1014.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 31, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2f46af05ce2d43e19e0095680eb3a52fd904c774 8280132: Incorrect comparator com.sun.beans.introspect.MethodInfo.MethodOrder Dec 31, 2022
@openjdk
Copy link

openjdk bot commented Dec 31, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 31, 2022

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280132: Incorrect comparator com.sun.beans.introspect.MethodInfo.MethodOrder

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 31, 2022
@mrserb mrserb marked this pull request as ready for review January 1, 2023 04:20
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 1, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 1, 2023

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Jan 3, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 3, 2023

Going to push as commit ef94eb7.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 0ac93eb: 8295066: Folding of loads is broken in C2 after JDK-8242115
  • abfa08f: 8242115: C2 SATB barriers are not safepoint-safe
  • 0aa62ae: 8294378: URLPermission constructor exception when using tr locale
  • 6f5fdb3: 8296239: ISO 4217 Amendment 174 Update
  • 9a2743f: 8296136: Use correct register in aarch64_enc_fast_unlock()
  • 7be0b5a: 8293531: C2: some vectorapi tests fail assert "Not monotonic" with flag -XX:TypeProfileLevel=222
  • aa8a841: 8290964: C2 compilation fails with assert "non-reduction loop contains reduction nodes"
  • 61e27b4: 8292780: misc tests failed "assert(false) failed: graph should be schedulable"
  • 43668f9: 8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop
  • 330105c: 8292602: ZGC: C2 late barrier analysis uses invalid dominator information
  • ... and 8 more: https://git.openjdk.org/jdk17u-dev/compare/82790b03da58d812e6067e12d66424fa32252dc4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 3, 2023
@openjdk openjdk bot closed this Jan 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 3, 2023
@openjdk
Copy link

openjdk bot commented Jan 3, 2023

@mrserb Pushed as commit ef94eb7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant