8285835: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work

[GoeLin]

I backport this for parity with 17.0.7-oracle.

I had to resolve one hunk in escape.cpp because head has more tracing code at that
place. Old code calls set_scalar_replaceable(false), new code
calls set_not_scalar_replaceable(...) which traces and calls the
other method.
Instead of editing the new code, I keep the tracing call and add
that method in escape.hpp. But I stripped the output of the
tracing, as it would be incomplete as long as I don't fix all
occurances.
The tracing was added by "8281548: Add escape analysis tracing flag"

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8285835: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer) ⚠️ Review applies to 13987dff

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1023/head:pull/1023
$ git checkout pull/1023

Update a local copy of the PR:
$ git checkout pull/1023
$ git pull https://git.openjdk.org/jdk17u-dev pull/1023/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1023

View PR using the GUI difftool:
$ git pr show -t 1023

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1023.diff

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[mlbridge]

Webrevs

• 01: Full - Incremental (e611889d)
• 00: Full (13987dff)

[TheRealMDoerr]

LGTM. Please fix comment indentation before integrating.

[TheRealMDoerr]

Odd indentation.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285835: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• c95dda4: 8286800: Assert in PhaseIdealLoop::dump_real_LCA is too strong
• 0ce1205: 8294947: Use 64bit atomics in patch_verified_entry on x86_64
• 3a019fd: 8294217: Assertion failure: parsing found no loops but there are some
• c9bbd55: 8292159: TYPE_USE annotations on generic type arguments of record components discarded
• 013709f: 8294538: missing is_unloading() check in SharedRuntime::fixup_callers_callsite()
• 6469c30: 8295414: [Aarch64] C2: assert(false) failed: bad AD file
• 26f0348: 8280868: LineBodyHandlerTest.java creates and discards too many clients
• d3c4a14: 8280553: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java can fail if GC occurs
• 3762bd0: 8270476: Make floating-point test infrastructure more lambda and method reference friendly
• bd58dd8: 8212961: [TESTBUG] vmTestbase/nsk/stress/jni/ native code cleanup
• ... and 3 more: https://git.openjdk.org/jdk17u-dev/compare/09160322d46c587df40df654e2e2cccbde0adeac...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[GoeLin]

/integrate

[openjdk]

Going to push as commit 3e7f840.
Since your change was applied there have been 14 commits pushed to the master branch:

• 95f23f7: 8292177: InitialSecurityProperty JFR event
• c95dda4: 8286800: Assert in PhaseIdealLoop::dump_real_LCA is too strong
• 0ce1205: 8294947: Use 64bit atomics in patch_verified_entry on x86_64
• 3a019fd: 8294217: Assertion failure: parsing found no loops but there are some
• c9bbd55: 8292159: TYPE_USE annotations on generic type arguments of record components discarded
• 013709f: 8294538: missing is_unloading() check in SharedRuntime::fixup_callers_callsite()
• 6469c30: 8295414: [Aarch64] C2: assert(false) failed: bad AD file
• 26f0348: 8280868: LineBodyHandlerTest.java creates and discards too many clients
• d3c4a14: 8280553: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java can fail if GC occurs
• 3762bd0: 8270476: Make floating-point test infrastructure more lambda and method reference friendly
• ... and 4 more: https://git.openjdk.org/jdk17u-dev/compare/09160322d46c587df40df654e2e2cccbde0adeac...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 3e7f840.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.