-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8277137: Set OnSpinWaitInst/OnSpinWaitInstCount defaults to "isb"/1 for Arm Neoverse N1 #103
Conversation
👋 Welcome back eastig! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@eastig This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
Going to push as commit fe1d8e9.
Your commit was automatically rebased without conflicts. |
@phohensee @eastig Pushed as commit fe1d8e9. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Tested:
make test TEST=gtest
: Passedmake run-test TEST=tier1
: Passedmake run-test TEST=tier2
: Passedmake run-test TEST=hotspot/jtreg/compiler/onSpinWait
: Passed with an expected failureExpected failure: https://bugs.openjdk.java.net/browse/JDK-8277503
The failure will be fixed by the backport of JDK-8277503.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/103/head:pull/103
$ git checkout pull/103
Update a local copy of the PR:
$ git checkout pull/103
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/103/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 103
View PR using the GUI difftool:
$ git pr show -t 103
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/103.diff