Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277137: Set OnSpinWaitInst/OnSpinWaitInstCount defaults to "isb"/1 for Arm Neoverse N1 #103

Closed
wants to merge 1 commit into from

Conversation

eastig
Copy link
Member

@eastig eastig commented Jan 18, 2022

Tested:

  • make test TEST=gtest: Passed
  • make run-test TEST=tier1: Passed
  • make run-test TEST=tier2: Passed
  • make run-test TEST=hotspot/jtreg/compiler/onSpinWait: Passed with an expected failure

Expected failure: https://bugs.openjdk.java.net/browse/JDK-8277503
The failure will be fixed by the backport of JDK-8277503.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277137: Set OnSpinWaitInst/OnSpinWaitInstCount defaults to "isb"/1 for Arm Neoverse N1

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/103/head:pull/103
$ git checkout pull/103

Update a local copy of the PR:
$ git checkout pull/103
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/103/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 103

View PR using the GUI difftool:
$ git pr show -t 103

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/103.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 18, 2022

👋 Welcome back eastig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 38345bd28db83371676f1685806ddc207a833879 8277137: Set OnSpinWaitInst/OnSpinWaitInstCount defaults to "isb"/1 for Arm Neoverse N1 Jan 18, 2022
@openjdk
Copy link

openjdk bot commented Jan 18, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 18, 2022

@eastig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277137: Set OnSpinWaitInst/OnSpinWaitInstCount defaults to "isb"/1 for Arm Neoverse N1

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 36fc98b: 8273341: Update Siphash to version 1.0
  • 3ca676c: 8269032: Stringdedup tests are failing if the ergonomically select GC does not support it

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 18, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 18, 2022

Webrevs

@eastig
Copy link
Member Author

eastig commented Jan 20, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 20, 2022
@openjdk
Copy link

openjdk bot commented Jan 20, 2022

@eastig
Your change (at version 695a789) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 20, 2022

Going to push as commit fe1d8e9.
Since your change was applied there have been 65 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 20, 2022
@openjdk openjdk bot closed this Jan 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 20, 2022
@openjdk
Copy link

openjdk bot commented Jan 20, 2022

@phohensee @eastig Pushed as commit fe1d8e9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants