Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297088: Update LCMS to 2.14 #1030

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 4, 2023

I backport this for parity with 17.0.7-oracle.

Omitted patch to Asw2dLibraries.gmk as the warning is already disabled in 17.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1030/head:pull/1030
$ git checkout pull/1030

Update a local copy of the PR:
$ git checkout pull/1030
$ git pull https://git.openjdk.org/jdk17u-dev pull/1030/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1030

View PR using the GUI difftool:
$ git pr show -t 1030

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1030.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 4, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2c692aa3567fff446b1a3263023077d8b4236945 8297088: Update LCMS to 2.14 Jan 4, 2023
@openjdk
Copy link

openjdk bot commented Jan 4, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 4, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 4, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 4, 2023

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Jan 9, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297088: Update LCMS to 2.14

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 339b93b: 8297431: [JVMCI] HotSpotJVMCIRuntime.encodeThrowable should not throw an exception
  • b427938: 8297569: URLPermission constructor throws IllegalArgumentException: Invalid characters in hostname after JDK-8294378

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 9, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Jan 10, 2023

Thanks for the review!

@GoeLin
Copy link
Member Author

GoeLin commented Jan 10, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 10, 2023

Going to push as commit f2c3f35.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 1dc6a38: 8277822: Remove debug-only heap overrun checks in os::malloc and friends
  • c370dec: 8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows
  • 339b93b: 8297431: [JVMCI] HotSpotJVMCIRuntime.encodeThrowable should not throw an exception
  • b427938: 8297569: URLPermission constructor throws IllegalArgumentException: Invalid characters in hostname after JDK-8294378

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 10, 2023
@openjdk openjdk bot closed this Jan 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2023
@openjdk
Copy link

openjdk bot commented Jan 10, 2023

@GoeLin Pushed as commit f2c3f35.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8295788 branch February 8, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants