Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295788: C2 compilation hits "assert((mode == ControlAroundStripMined && use == sfpt) || !use->is_reachable_from_root()) failed: missed a node" #1031

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 4, 2023

I backport this for parity with 17.0.7-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295788: C2 compilation hits "assert((mode == ControlAroundStripMined && use == sfpt) || !use->is_reachable_from_root()) failed: missed a node"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1031/head:pull/1031
$ git checkout pull/1031

Update a local copy of the PR:
$ git checkout pull/1031
$ git pull https://git.openjdk.org/jdk17u-dev pull/1031/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1031

View PR using the GUI difftool:
$ git pr show -t 1031

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1031.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 4, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 761a4f4852cbb40660b6fb9eda4d740464218f75 8295788: C2 compilation hits "assert((mode == ControlAroundStripMined && use == sfpt) || !use->is_reachable_from_root()) failed: missed a node" Jan 4, 2023
@openjdk
Copy link

openjdk bot commented Jan 4, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 4, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295788: C2 compilation hits "assert((mode == ControlAroundStripMined && use == sfpt) || !use->is_reachable_from_root()) failed: missed a node"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 4, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 4, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jan 5, 2023

Pre-submit test:
Failed.`main' threw exception: java.lang.IllegalStateException: This segment is already closed in TestAsyncSocketChannels
Seems unrelated, but better rerun tests.

@GoeLin
Copy link
Member Author

GoeLin commented Jan 12, 2023

Finally the tests are green :)
/integrate

@openjdk
Copy link

openjdk bot commented Jan 12, 2023

Going to push as commit ffecc39.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 520ae87: 8284165: Add pid to process reaper thread name
  • 3722edc: 8284726: Print active locale settings in hs_err reports and in VM.info
  • 2defeb0: 8290067: Show stack dimensions in UL logging when attaching threads
  • 072bdfb: 8297523: Various GetPrimitiveArrayCritical miss result - NULL check
  • fea3818: 8280784: VM_Cleanup unnecessarily processes all thread oops

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 12, 2023
@openjdk openjdk bot closed this Jan 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 12, 2023
@openjdk
Copy link

openjdk bot commented Jan 12, 2023

@GoeLin Pushed as commit ffecc39.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant