8277822: Remove debug-only heap overrun checks in os::malloc and friends

[tstuefe]

After we backported "8275320: NMT should perform buffer overrun checks", I'd like to backport this one as well.This change removes now redundant overrun checks from os::malloc and friends.

Not a clean backport, but the fix is small. There had been a security fix: "8286519: Better memory handling" sits in the middle of the backporting chains. It did introduce a size overflow check that I had to move and adapt (lines 694-697).

  // Check for overflow.
  if (outer_size < size) {
    return NULL;
  }

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8277822: Remove debug-only heap overrun checks in os::malloc and friends

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1041/head:pull/1041
$ git checkout pull/1041

Update a local copy of the PR:
$ git checkout pull/1041
$ git pull https://git.openjdk.org/jdk17u-dev pull/1041/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1041

View PR using the GUI difftool:
$ git pr show -t 1041

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1041.diff

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (e8f02409)

[phohensee]

Lgtm.

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277822: Remove debug-only heap overrun checks in os::malloc and friends

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 339b93b: 8297431: [JVMCI] HotSpotJVMCIRuntime.encodeThrowable should not throw an exception
• b427938: 8297569: URLPermission constructor throws IllegalArgumentException: Invalid characters in hostname after JDK-8294378
• ad04159: 8296912: C2: CreateExNode::Identity fails with assert(i < _max) failed: oob: i=1, _max=1
• d784aae: 8276064: CheckCastPP with raw oop input floats below a safepoint
• cf6c041: 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tstuefe]

Lgtm.

Thank you Paul!

[tstuefe]

Got approval

/integrate

[openjdk]

Going to push as commit 1dc6a38.
Since your change was applied there have been 6 commits pushed to the master branch:

• c370dec: 8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows
• 339b93b: 8297431: [JVMCI] HotSpotJVMCIRuntime.encodeThrowable should not throw an exception
• b427938: 8297569: URLPermission constructor throws IllegalArgumentException: Invalid characters in hostname after JDK-8294378
• ad04159: 8296912: C2: CreateExNode::Identity fails with assert(i < _max) failed: oob: i=1, _max=1
• d784aae: 8276064: CheckCastPP with raw oop input floats below a safepoint
• cf6c041: 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR

Your commit was automatically rebased without conflicts.

[openjdk]

@tstuefe Pushed as commit 1dc6a38.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.