Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284165: Add pid to process reaper thread name #1046

Closed
wants to merge 1 commit into from

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Jan 10, 2023

I'd like to downport this patch since it is a small improvement that comes in very handy when analyzing mass-fork scenarios.

Does not apply cleanly: Original patch modifies test/jdk/java/lang/ProcessBuilder/ProcessReaperCCL.java but that test does not exist in 17u yet. Left the hunk out.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1046/head:pull/1046
$ git checkout pull/1046

Update a local copy of the PR:
$ git checkout pull/1046
$ git pull https://git.openjdk.org/jdk17u-dev pull/1046/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1046

View PR using the GUI difftool:
$ git pr show -t 1046

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1046.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2023

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9561b5e041c4cc70319e60953819c521c1e68d6c 8284165: Add pid to process reaper thread name Jan 10, 2023
@openjdk
Copy link

openjdk bot commented Jan 10, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 10, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 10, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Jan 10, 2023

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284165: Add pid to process reaper thread name

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 10, 2023
@tstuefe
Copy link
Member Author

tstuefe commented Jan 12, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 12, 2023

Going to push as commit 520ae87.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 3722edc: 8284726: Print active locale settings in hs_err reports and in VM.info
  • 2defeb0: 8290067: Show stack dimensions in UL logging when attaching threads
  • 072bdfb: 8297523: Various GetPrimitiveArrayCritical miss result - NULL check
  • fea3818: 8280784: VM_Cleanup unnecessarily processes all thread oops
  • f2c3f35: 8297088: Update LCMS to 2.14

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 12, 2023
@openjdk openjdk bot closed this Jan 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 12, 2023
@openjdk
Copy link

openjdk bot commented Jan 12, 2023

@tstuefe Pushed as commit 520ae87.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tstuefe tstuefe deleted the tstuefe-backport-9561b5e0 branch January 30, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants