-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8284165: Add pid to process reaper thread name #1046
Conversation
👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@tstuefe This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 520ae87.
Your commit was automatically rebased without conflicts. |
I'd like to downport this patch since it is a small improvement that comes in very handy when analyzing mass-fork scenarios.
Does not apply cleanly: Original patch modifies test/jdk/java/lang/ProcessBuilder/ProcessReaperCCL.java but that test does not exist in 17u yet. Left the hunk out.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1046/head:pull/1046
$ git checkout pull/1046
Update a local copy of the PR:
$ git checkout pull/1046
$ git pull https://git.openjdk.org/jdk17u-dev pull/1046/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1046
View PR using the GUI difftool:
$ git pr show -t 1046
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1046.diff