Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275582: Don't purge metaspace mapping lists #1048

Closed

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Jan 10, 2023

I'd like to downport this, since it is a prerequisite for downporting JDK-8275704
"Metaspace::contains() should be threadsafe".


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1048/head:pull/1048
$ git checkout pull/1048

Update a local copy of the PR:
$ git checkout pull/1048
$ git pull https://git.openjdk.org/jdk17u-dev pull/1048/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1048

View PR using the GUI difftool:
$ git pr show -t 1048

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1048.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2023

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3ff085e2967508ad312c9d32fa908807aefe69ee 8275582: Don't purge metaspace mapping lists Jan 10, 2023
@openjdk
Copy link

openjdk bot commented Jan 10, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 10, 2023

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275582: Don't purge metaspace mapping lists

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 10, 2023

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Jan 11, 2023

Why is the Pre-submit test failing?
I remove the fix request tag in the meantime.

@tstuefe
Copy link
Member Author

tstuefe commented Jan 12, 2023

Why is the Pre-submit test failing? I remove the fix request tag in the meantime.

The 32-bit release build failed because of GHA infra problems. The 32-bit debug build succeeded though. But the x86 tests did not run because the release build was not finished (we may want to look into this: if debug built, debug should be tested even if release failed to build. Or do we need release for testing?)

Anyway, since the PR branch is owned by the Skara bot, I am not sure how to re-trigger the GHA tests. For my own branches, I just push a new empty commit. But how do I do this here? @RealCLanger do you know?

@tstuefe
Copy link
Member Author

tstuefe commented Jan 12, 2023

I executed Metaspace related jtreg and -gtests on 32-bit debug locally, all is fine as expected. The patch was also tested in our nightlies for two nights in a row.

@GoeLin
Copy link
Member

GoeLin commented Jan 12, 2023

Thanks, just to make sure it's not your change causing this.

@GoeLin
Copy link
Member

GoeLin commented Jan 12, 2023

Theoretically, if you click on the Details link above and then go to the job, there is as redo button at the top right.
But so far it never worked for me. I rather merge in head by navigating to the branch and clicking "sync-fork"

@tstuefe
Copy link
Member Author

tstuefe commented Jan 27, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 27, 2023

Going to push as commit f6ad61c.
Since your change was applied there have been 61 commits pushed to the master branch:

  • b7d83f4: 8293466: libjsig should ignore non-modifying sigaction calls
  • fae1628: 8293493: Signal Handlers printout should show signal block state
  • d1ad596: 8293691: converting a defined BasicType value to a string should not crash the VM
  • 229288b: 8277946: NMT: Remove VM.native_memory shutdown jcmd command option
  • d3c93e7: 8280048: Missing comma in copyright header
  • 1cee8aa: 8231491: JDI tc02x004 failed again due to wrong # of breakpoints
  • fde708b: 8282771: Create test case for JDK-8262981
  • 2f9983c: 8285690: CloneableReference subtest should not throw CloneNotSupportedException
  • 8c2a6bd: 8144030: [macosx] test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails (again)
  • 3993301: 8287491: compiler/jvmci/errors/TestInvalidDebugInfo.java fails new assert: assert((uint)t < T_CONFLICT + 1) failed: invalid type #
  • ... and 51 more: https://git.openjdk.org/jdk17u-dev/compare/6e544c20c991166f767ab00f9a306f41d2bc54ca...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 27, 2023
@openjdk openjdk bot closed this Jan 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 27, 2023
@openjdk
Copy link

openjdk bot commented Jan 27, 2023

@tstuefe Pushed as commit f6ad61c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants