New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8275582: Don't purge metaspace mapping lists #1048
Conversation
👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@tstuefe This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
Why is the Pre-submit test failing? |
The 32-bit release build failed because of GHA infra problems. The 32-bit debug build succeeded though. But the x86 tests did not run because the release build was not finished (we may want to look into this: if debug built, debug should be tested even if release failed to build. Or do we need release for testing?) Anyway, since the PR branch is owned by the Skara bot, I am not sure how to re-trigger the GHA tests. For my own branches, I just push a new empty commit. But how do I do this here? @RealCLanger do you know? |
I executed Metaspace related jtreg and -gtests on 32-bit debug locally, all is fine as expected. The patch was also tested in our nightlies for two nights in a row. |
Thanks, just to make sure it's not your change causing this. |
Theoretically, if you click on the Details link above and then go to the job, there is as redo button at the top right. |
/integrate |
Going to push as commit f6ad61c.
Your commit was automatically rebased without conflicts. |
I'd like to downport this, since it is a prerequisite for downporting JDK-8275704
"Metaspace::contains() should be threadsafe".
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1048/head:pull/1048
$ git checkout pull/1048
Update a local copy of the PR:
$ git checkout pull/1048
$ git pull https://git.openjdk.org/jdk17u-dev pull/1048/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1048
View PR using the GUI difftool:
$ git pr show -t 1048
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1048.diff