Skip to content

8293466: libjsig should ignore non-modifying sigaction calls#1049

Closed
tstuefe wants to merge 3 commits intoopenjdk:masterfrom
openjdk-bots:tstuefe-backport-b1ed40a8
Closed

8293466: libjsig should ignore non-modifying sigaction calls#1049
tstuefe wants to merge 3 commits intoopenjdk:masterfrom
openjdk-bots:tstuefe-backport-b1ed40a8

Conversation

@tstuefe
Copy link
Member

@tstuefe tstuefe commented Jan 10, 2023

Small fix that fixes corner cases with signal chaining in libjsig.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293466: libjsig should ignore non-modifying sigaction calls

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1049/head:pull/1049
$ git checkout pull/1049

Update a local copy of the PR:
$ git checkout pull/1049
$ git pull https://git.openjdk.org/jdk17u-dev pull/1049/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1049

View PR using the GUI difftool:
$ git pr show -t 1049

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1049.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2023

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b1ed40a87ab357d1b51ac5102bba181f21ffa9b6 8293466: libjsig should ignore non-modifying sigaction calls Jan 10, 2023
@openjdk
Copy link

openjdk bot commented Jan 10, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jan 10, 2023
@openjdk
Copy link

openjdk bot commented Jan 10, 2023

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293466: libjsig should ignore non-modifying sigaction calls

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 10, 2023

Webrevs

@tstuefe
Copy link
Member Author

tstuefe commented Jan 27, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 27, 2023

Going to push as commit b7d83f4.
Since your change was applied there have been 19 commits pushed to the master branch:

  • fae1628: 8293493: Signal Handlers printout should show signal block state
  • d1ad596: 8293691: converting a defined BasicType value to a string should not crash the VM
  • 229288b: 8277946: NMT: Remove VM.native_memory shutdown jcmd command option
  • d3c93e7: 8280048: Missing comma in copyright header
  • 1cee8aa: 8231491: JDI tc02x004 failed again due to wrong # of breakpoints
  • fde708b: 8282771: Create test case for JDK-8262981
  • 2f9983c: 8285690: CloneableReference subtest should not throw CloneNotSupportedException
  • 8c2a6bd: 8144030: [macosx] test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails (again)
  • 3993301: 8287491: compiler/jvmci/errors/TestInvalidDebugInfo.java fails new assert: assert((uint)t < T_CONFLICT + 1) failed: invalid type #
  • b3a8ad5: 6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion
  • ... and 9 more: https://git.openjdk.org/jdk17u-dev/compare/0056a6330bb2e806ea47da0c51af0ab095feb25d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 27, 2023
@openjdk openjdk bot closed this Jan 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 27, 2023
@openjdk
Copy link

openjdk bot commented Jan 27, 2023

@tstuefe Pushed as commit b7d83f4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant