-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8299789: Compilation of gtest causes build to fail if runtime libraries are in different dirs #1051
Conversation
👋 Welcome back serb! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@mrserb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 1032a0f.
Your commit was automatically rebased without conflicts. |
Hi all,
This pull request contains a backport of commit c8a8388a from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 10 Jan 2023 and was reviewed by Erik Joelsson.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1051/head:pull/1051
$ git checkout pull/1051
Update a local copy of the PR:
$ git checkout pull/1051
$ git pull https://git.openjdk.org/jdk17u-dev pull/1051/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1051
View PR using the GUI difftool:
$ git pr show -t 1051
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1051.diff