Skip to content

8144030: [macosx] test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails (again)#1053

Closed
masyano wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:masyano-backport-e5041ae3
Closed

8144030: [macosx] test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails (again)#1053
masyano wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:masyano-backport-e5041ae3

Conversation

@masyano
Copy link

@masyano masyano commented Jan 11, 2023

This is a backport of JDK-8144030: [macosx] test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails (again).
The original patch applies cleanly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8144030: [macosx] test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails (again)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1053/head:pull/1053
$ git checkout pull/1053

Update a local copy of the PR:
$ git checkout pull/1053
$ git pull https://git.openjdk.org/jdk17u-dev pull/1053/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1053

View PR using the GUI difftool:
$ git pr show -t 1053

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1053.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 11, 2023

👋 Welcome back myano! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e5041ae3d45b43be10d5da747d773882ebf0482b 8144030: [macosx] test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails (again) Jan 11, 2023
@openjdk
Copy link

openjdk bot commented Jan 11, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jan 11, 2023
@openjdk
Copy link

openjdk bot commented Jan 11, 2023

@masyano This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8144030: [macosx] test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails (again)

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 101 new commits pushed to the master branch:

  • cc56820: 8296389: C2: PhaseCFG::convert_NeverBranch_to_Goto must handle both orders of successors
  • 1d6db44: 8297642: PhaseIdealLoop::only_has_infinite_loops must detect all loops that never lead to termination
  • b5c7a6f: 8290850: C2: create_new_if_for_predicate() does not clone pinned phi input nodes resulting in a broken graph
  • 127f3eb: 8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java
  • 044eb4e: 8273154: Provide a JavadocTester method for non-overlapping, unordered output matching
  • 5872c77: 8254267: javax/xml/crypto/dsig/LogParameters.java failed with "RuntimeException: Unexpected log output:"
  • 7043b63: 8295211: Fix autoconf 2.71 warning "AC_CHECK_HEADERS: you should use literals"
  • e490cad: 8279351: [TESTBUG] SADebugDTest.java does not handle "Address already in use" error
  • 1032a0f: 8299789: Compilation of gtest causes build to fail if runtime libraries are in different dirs
  • 4780e49: 8299424: containers/docker/TestMemoryWithCgroupV1.java fails on SLES12 ppc64le when testing Memory and Swap Limit
  • ... and 91 more: https://git.openjdk.org/jdk17u-dev/compare/e0368a2a48111a0f0ddfeb3a5a5342677fa11e0c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 11, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 11, 2023

Webrevs

@masyano
Copy link
Author

masyano commented Jan 17, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 17, 2023
@openjdk
Copy link

openjdk bot commented Jan 17, 2023

@masyano
Your change (at version f5a3c69) is now ready to be sponsored by a Committer.

@mrserb
Copy link
Member

mrserb commented Jan 25, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 25, 2023

Going to push as commit 8c2a6bd.
Since your change was applied there have been 142 commits pushed to the master branch:

  • 3993301: 8287491: compiler/jvmci/errors/TestInvalidDebugInfo.java fails new assert: assert((uint)t < T_CONFLICT + 1) failed: invalid type #
  • b3a8ad5: 6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion
  • b3e305e: 8294705: Disable an assertion in test/jdk/java/util/DoubleStreamSums/CompensatedSums.java
  • 46c1434: 8286562: GCC 12 reports some compiler warnings
  • 0720b24: 8299497: Usage of constructors of primitive wrapper classes should be avoided in java.desktop API docs
  • a34f2d3: 8300773: Address the inconsistency between the constant array and pool size
  • ba956c5: 8208077: File.listRoots performance degradation
  • 62ccb39: 8295685: Update Libpng to 1.6.38
  • ba023c6: 8297264: C2: Cast node is not processed again in CCP and keeps a wrong too narrow type which is later replaced by top
  • 40b5f15: 8287180: Update IANA Language Subtag Registry to Version 2022-08-08
  • ... and 132 more: https://git.openjdk.org/jdk17u-dev/compare/e0368a2a48111a0f0ddfeb3a5a5342677fa11e0c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 25, 2023
@openjdk openjdk bot closed this Jan 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 25, 2023
@openjdk
Copy link

openjdk bot commented Jan 25, 2023

@mrserb @masyano Pushed as commit 8c2a6bd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants