8296389: C2: PhaseCFG::convert_NeverBranch_to_Goto must handle both orders of successors

[GoeLin]

I backport this for parity with 17.0.7-oracle.

I added nique_ctrl_out_or_null() to workaround 8281732
missing in 17 in node.hpp
I include 8298568 to not break the build.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8296389: C2: PhaseCFG::convert_NeverBranch_to_Goto must handle both orders of successors
• JDK-8298568: Fastdebug build fails after JDK-8296389

Reviewers

• Richard Reingruber (@reinrich - Reviewer) ⚠️ Review applies to 17975842

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1059/head:pull/1059
$ git checkout pull/1059

Update a local copy of the PR:
$ git checkout pull/1059
$ git pull https://git.openjdk.org/jdk17u-dev pull/1059/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1059

View PR using the GUI difftool:
$ git pr show -t 1059

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1059.diff

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 03: Full - Incremental (07e6018e)
• 02: Full - Incremental (17975842)
• 01: Full - Incremental (16ab3b02)
• 00: Full (16ab3b02)

[GoeLin]

/issue JDK-8298568

[openjdk]

@GoeLin
Adding additional issue to issue list: 8298568: Fastdebug build fails after JDK-8296389.

[reinrich]

Looks good.
Thanks, Richard.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296389: C2: PhaseCFG::convert_NeverBranch_to_Goto must handle both orders of successors
8298568: Fastdebug build fails after JDK-8296389

Reviewed-by: rrich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[GoeLin]

/integrate

[openjdk]

Going to push as commit cc56820.

[openjdk]

@GoeLin Pushed as commit cc56820.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.