Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java #1064

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 12, 2023

I backport this for parity with 17.0.7-oracle.

I resolved copyright and the @run command.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1064/head:pull/1064
$ git checkout pull/1064

Update a local copy of the PR:
$ git checkout pull/1064
$ git pull https://git.openjdk.org/jdk17u-dev pull/1064/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1064

View PR using the GUI difftool:
$ git pr show -t 1064

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1064.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c17a0122c4b5f17b85dc0bee0777b2a831debf6d 8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java Jan 12, 2023
@openjdk
Copy link

openjdk bot commented Jan 12, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 12, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 12, 2023

Webrevs

Copy link
Member

@reinrich reinrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thanks, Richard.

@openjdk
Copy link

openjdk bot commented Jan 16, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java

Reviewed-by: rrich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • e490cad: 8279351: [TESTBUG] SADebugDTest.java does not handle "Address already in use" error
  • 1032a0f: 8299789: Compilation of gtest causes build to fail if runtime libraries are in different dirs
  • 4780e49: 8299424: containers/docker/TestMemoryWithCgroupV1.java fails on SLES12 ppc64le when testing Memory and Swap Limit
  • 63da2b0: 8295413: com/sun/jdi/EATests.java fails with compiler flag -XX:+StressReflectiveCode

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 16, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Jan 16, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 16, 2023

Going to push as commit 127f3eb.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 044eb4e: 8273154: Provide a JavadocTester method for non-overlapping, unordered output matching
  • 5872c77: 8254267: javax/xml/crypto/dsig/LogParameters.java failed with "RuntimeException: Unexpected log output:"
  • 7043b63: 8295211: Fix autoconf 2.71 warning "AC_CHECK_HEADERS: you should use literals"
  • e490cad: 8279351: [TESTBUG] SADebugDTest.java does not handle "Address already in use" error
  • 1032a0f: 8299789: Compilation of gtest causes build to fail if runtime libraries are in different dirs
  • 4780e49: 8299424: containers/docker/TestMemoryWithCgroupV1.java fails on SLES12 ppc64le when testing Memory and Swap Limit
  • 63da2b0: 8295413: com/sun/jdi/EATests.java fails with compiler flag -XX:+StressReflectiveCode

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 16, 2023
@openjdk openjdk bot closed this Jan 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 16, 2023
@openjdk
Copy link

openjdk bot commented Jan 16, 2023

@GoeLin Pushed as commit 127f3eb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8278961 branch January 16, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants