Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287754: Update jib GNU make dependency on Windows to latest cygwin build #1074

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 17, 2023

I backport this for parity with 17.0.7-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287754: Update jib GNU make dependency on Windows to latest cygwin build

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1074/head:pull/1074
$ git checkout pull/1074

Update a local copy of the PR:
$ git checkout pull/1074
$ git pull https://git.openjdk.org/jdk17u-dev pull/1074/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1074

View PR using the GUI difftool:
$ git pr show -t 1074

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1074.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 17, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport af2de975cbc46ad91c736b110a2212cd32ba60a7 8287754: Update jib GNU make dependency on Windows to latest cygwin build Jan 17, 2023
@openjdk
Copy link

openjdk bot commented Jan 17, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 17, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287754: Update jib GNU make dependency on Windows to latest cygwin build

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 17, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 17, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jan 23, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 23, 2023

Going to push as commit 68c025b.
Since your change was applied there have been 27 commits pushed to the master branch:

  • 571f5f5: 8300119: CgroupMetrics.getTotalMemorySize0() can report invalid results on 32 bit systems
  • b7be2bd: 8272985: Reference discovery is confused about atomicity and degree of parallelism
  • 48d5259: 8300490: Spaces in name of MacOS Code Signing Identity are not correctly handled after JDK-8293550
  • b3e16fc: 8300642: [17u,11u] Fix DEFAULT_PROMOTED_VERSION_PRE=ea for -dev
  • 4895228: 8285919: Remove debug printout from JDK-8285093
  • c20415b: 8282143: Objects.requireNonNull should be ForceInline
  • bca0856: 8285755: JDK-8285093 changed the default for --with-output-sync
  • 38b60a2: Merge
  • 2fe4285: 8299392: [17u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 17.0.6
  • 02f5815: 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR
  • ... and 17 more: https://git.openjdk.org/jdk17u-dev/compare/48b8fec1125528763222525aff587a3711ac71c1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 23, 2023
@openjdk openjdk bot closed this Jan 23, 2023
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jan 23, 2023
@GoeLin GoeLin deleted the goetz_backport_8287754 branch January 23, 2023 11:27
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jan 23, 2023
@openjdk
Copy link

openjdk bot commented Jan 23, 2023

@GoeLin Pushed as commit 68c025b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant