8299677: Formatter.format might take a long time to format an integer or floating-point #1077

phohensee · 2023-01-17T17:11:04Z

Simple almost clean backport of a potential DOS attack vector fix. Copyright date conflict plus changed

Flags.contains(f, Flags.ZERO_PAD)

to

f.contains(Flags.ZERO_PAD)

Passes new and old Formatter tests.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8299677: Formatter.format might take a long time to format an integer or floating-point (Bug - P4)

Reviewers

Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1077/head:pull/1077
$ git checkout pull/1077

Update a local copy of the PR:
$ git checkout pull/1077
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1077/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1077

View PR using the GUI difftool:
$ git pr show -t 1077

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1077.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-01-17T17:12:11Z

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-01-17T17:13:15Z

This backport pull request has now been updated with issue from the original commit.

mlbridge · 2023-01-17T17:18:29Z

Webrevs

phohensee · 2023-01-18T18:50:40Z

The pre-submit test failures occur because the new test, Padding.java, fails compilation by jtreg because Padding.java imports org.junit.jupiter. The latter is available in jtreg version 7.2, which I run on my test machines, but is not available in the version of jtreg used to run the pre-submit tests. The jtreg version used to run the pre-submit tests should be upgraded because otherwise backporting new tests will difficult/impossible without rewrites.

bridgekeeper · 2023-02-24T18:26:11Z

@phohensee This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

phohensee · 2023-02-24T18:31:39Z

/open

openjdk · 2023-02-24T18:33:06Z

@phohensee This pull request is already open

bridgekeeper · 2023-03-24T20:38:49Z

@phohensee This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper · 2023-04-21T22:55:59Z

@phohensee This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

phohensee · 2023-04-22T14:31:14Z

/open

openjdk · 2023-04-22T14:32:06Z

@phohensee This pull request is now open

RealCLanger · 2023-04-24T05:29:21Z

The test seems to fail in GHA...

TheRealMDoerr

LGTM.

openjdk · 2023-04-26T14:42:31Z

@phohensee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299677: Formatter.format might take a long time to format an integer or floating-point

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

TheRealMDoerr · 2023-04-26T14:53:31Z

The test seems to fail in GHA...

Indeed. Is this a localization issue?
expected: <1.2> but was: <1,2>
The test has passed with -Duser.language=en-US
Some tests use Locale.setDefault. Maybe we should add that upstream (the test is failing upstream on the same machine, too).

bridgekeeper · 2023-05-24T22:05:57Z

@phohensee This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

phohensee · 2023-05-24T22:07:35Z

keep open.

bridgekeeper · 2023-07-13T20:19:58Z

@phohensee This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

…a and HeapByteBufferTest.java Backport-of: 7c1ebcc4ce74bb06f7c911e59a86bcfb5c5da844

…ith exit code 97 Backport-of: 1f438a8a702034c2f10c0008e72395f526b15ef5

Backport-of: 16a4f02f2d4f5574af3b20f2f0c788d15dd503ac

Reviewed-by: mdoerr Backport-of: 3b85f84f026973a2abdbce8d9baf1329c8a4ebf8

Reviewed-by: mdoerr Backport-of: e7795851d2e02389e63950fef939084b18ec4bfb

…va fails Backport-of: 812f475bc4ea84225e8bbb0b5a677eed0af864dd

Reviewed-by: phh, shade, andrew

Backport-of: 92d8326e4037605897d7c4eb4b3edb63a2fc11b0

Backport-of: 0901548833a0125f15fede64bc2e7dbe84fed42d

Reviewed-by: phh Backport-of: 538f9557b87f750264231f04bfbc91d15f8af8c0

…libfreetype-dev Reviewed-by: stuefe Backport-of: 69d900d2ce97e5479020cff9a63c471d07e39989

…nput/output error" in java.lang.ProcessHandleImpl$Info.info0 Backport-of: d24b7b7026cf85f1aecf44f60819762872cfd5c1

Reviewed-by: stuefe Backport-of: 9e4fc568a6f1a93c84a84d6cc5220c6eb4e546a5

…g: did not see the expected RSS reduction Reviewed-by: mdoerr Backport-of: ad34be1f329edc8e7155983835cc70d733c014b8

Reviewed-by: stuefe Backport-of: 20e94784c9f7c30e95550c72aedb5e986a153114

… are corrupted on Japanese Windows Reviewed-by: kevinw, cjplummer, phh

…it orientation Backport-of: d00a767047ec41e233e711dbc5fe7b8818e72f28

Backport-of: a3d67231a71fbe37c509fcedd54c679b4644c0d9

shipilev · 2023-09-05T14:18:00Z

Just pushed jtreg 7.3.1 update to 17u-dev. Try to merge from master and see if test works now, @phohensee.

TheRealMDoerr · 2023-09-06T11:09:18Z

The merge has messed up this PR. Can it be repaired or should we use a new one?
Oh, wait... The "Files changed" tab still looks good.

phohensee · 2023-09-06T14:17:28Z

Indeed it does. :) Thanks for the review!

phohensee · 2023-09-06T14:56:40Z

Martin, may I ask for a review of openjdk/jdk11u-dev#1667 as well? It's a clean backport from this one.

phohensee · 2023-09-07T13:19:24Z

/integrate

Approved.

openjdk · 2023-09-07T13:20:21Z

Going to push as commit 6b192d3.
Since your change was applied there have been 3 commits pushed to the master branch:

caaf942: Merge
dc00ae4: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge
a44f8b0: 8314960: Add Certigna Root CA - 2

Your commit was automatically rebased without conflicts.

openjdk · 2023-09-07T13:20:32Z

@phohensee Pushed as commit 6b192d3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot changed the title ~~Backport 33412c102ce799ff2de3512df77e6e07d76acd36~~ 8299677: Formatter.format might take a long time to format an integer or floating-point Jan 17, 2023

openjdk bot added backport rfr Pull request is ready for review labels Jan 17, 2023

phohensee mentioned this pull request Jan 17, 2023

8299677: Formatter.format might take a long time to format an integer or floating-point openjdk/jdk11u-dev#1667

Closed

4 tasks

bridgekeeper bot closed this Apr 21, 2023

openjdk bot reopened this Apr 22, 2023

TheRealMDoerr approved these changes Apr 26, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 26, 2023

GoeLin and others added 5 commits August 28, 2023 20:49

8299962: Speed up compiler/intrinsics/unsafe/DirectByteBufferTest.jav…

fdc4dc5

…a and HeapByteBufferTest.java Backport-of: 7c1ebcc4ce74bb06f7c911e59a86bcfb5c5da844

8282651: ZGC: vmTestbase/gc/ArrayJuggle/ tests fails intermittently w…

b97cf10

…ith exit code 97 Backport-of: 1f438a8a702034c2f10c0008e72395f526b15ef5

8302150: Speed up compiler/codegen/Test7100757.java

b35e489

Backport-of: 16a4f02f2d4f5574af3b20f2f0c788d15dd503ac

8309340: Provide sctpHandleSocketErrorWithMessage

25d49cb

Reviewed-by: mdoerr Backport-of: 3b85f84f026973a2abdbce8d9baf1329c8a4ebf8

8271707: migrate tests to use jdk.test.whitebox.WhiteBox

8f1a7a9

Reviewed-by: mdoerr Backport-of: e7795851d2e02389e63950fef939084b18ec4bfb

shipilev and others added 13 commits August 28, 2023 20:49

8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.ja…

00b3dc1

…va fails Backport-of: 812f475bc4ea84225e8bbb0b5a677eed0af864dd

8314552: Fix javadoc tests to work with jtreg 7

d5ad859

Reviewed-by: phh, shade, andrew

8299827: Add resolved IP address in connection exception for sockets

1d7d1ec

Backport-of: 92d8326e4037605897d7c4eb4b3edb63a2fc11b0

8283724: Incorrect description for jtreg-failure-handler option

2c9197a

Backport-of: 0901548833a0125f15fede64bc2e7dbe84fed42d

8313701: GHA: RISC-V should use the official repository for bootstrap

4372b37

Reviewed-by: phh Backport-of: 538f9557b87f750264231f04bfbc91d15f8af8c0

8314730: GHA: Drop libfreetype6-dev transitional package in favor of …

daf77d1

…libfreetype-dev Reviewed-by: stuefe Backport-of: 69d900d2ce97e5479020cff9a63c471d07e39989

8276651: java/lang/ProcessHandle tests fail with "RuntimeException: I…

dbe282c

…nput/output error" in java.lang.ProcessHandleImpl$Info.info0 Backport-of: d24b7b7026cf85f1aecf44f60819762872cfd5c1

8293114: JVM should trim the native heap

4483ba8

Reviewed-by: stuefe Backport-of: 9e4fc568a6f1a93c84a84d6cc5220c6eb4e546a5

8312525: New test runtime/os/TestTrimNative.java#trimNative is failin…

7cdad8a

…g: did not see the expected RSS reduction Reviewed-by: mdoerr Backport-of: ad34be1f329edc8e7155983835cc70d733c014b8

8314426: runtime/os/TestTrimNative.java is failing on slow machines

029c554

Reviewed-by: stuefe Backport-of: 20e94784c9f7c30e95550c72aedb5e986a153114

8313815: The exception messages printed by jcmd ManagementAgent.start…

97a32eb

… are corrupted on Japanese Windows Reviewed-by: kevinw, cjplummer, phh

8295737: macOS: Print content cut off when width > height with portra…

383950d

…it orientation Backport-of: d00a767047ec41e233e711dbc5fe7b8818e72f28

8311033: [macos] PrinterJob does not take into account Sides attribute

a4a674e

Backport-of: a3d67231a71fbe37c509fcedd54c679b4644c0d9

Merge branch 'master' into backport-8299677

ee7e986

openjdk bot removed the ready Pull request is ready to be integrated label Sep 5, 2023

Merge

b8c04b4

openjdk bot added the ready Pull request is ready to be integrated label Sep 5, 2023

TheRealMDoerr approved these changes Sep 6, 2023

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Sep 7, 2023

openjdk bot closed this Sep 7, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 7, 2023

phohensee deleted the backport-8299677 branch September 7, 2023 13:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8299677: Formatter.format might take a long time to format an integer or floating-point #1077

8299677: Formatter.format might take a long time to format an integer or floating-point #1077

phohensee commented Jan 17, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Jan 17, 2023

openjdk bot commented Jan 17, 2023

mlbridge bot commented Jan 17, 2023 •

edited

Loading

phohensee commented Jan 18, 2023

bridgekeeper bot commented Feb 24, 2023

phohensee commented Feb 24, 2023

openjdk bot commented Feb 24, 2023

bridgekeeper bot commented Mar 24, 2023

bridgekeeper bot commented Apr 21, 2023

phohensee commented Apr 22, 2023

openjdk bot commented Apr 22, 2023

RealCLanger commented Apr 24, 2023

TheRealMDoerr left a comment

openjdk bot commented Apr 26, 2023 •

edited

Loading

TheRealMDoerr commented Apr 26, 2023 •

edited

Loading

bridgekeeper bot commented May 24, 2023

phohensee commented May 24, 2023

bridgekeeper bot commented Jul 13, 2023

shipilev commented Sep 5, 2023

TheRealMDoerr commented Sep 6, 2023 •

edited

Loading

phohensee commented Sep 6, 2023

phohensee commented Sep 6, 2023

phohensee commented Sep 7, 2023

openjdk bot commented Sep 7, 2023

openjdk bot commented Sep 7, 2023

8299677: Formatter.format might take a long time to format an integer or floating-point #1077

8299677: Formatter.format might take a long time to format an integer or floating-point #1077

Conversation

phohensee commented Jan 17, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Jan 17, 2023

openjdk bot commented Jan 17, 2023

mlbridge bot commented Jan 17, 2023 • edited Loading

Webrevs

phohensee commented Jan 18, 2023

bridgekeeper bot commented Feb 24, 2023

phohensee commented Feb 24, 2023

openjdk bot commented Feb 24, 2023

bridgekeeper bot commented Mar 24, 2023

bridgekeeper bot commented Apr 21, 2023

phohensee commented Apr 22, 2023

openjdk bot commented Apr 22, 2023

RealCLanger commented Apr 24, 2023

TheRealMDoerr left a comment

Choose a reason for hiding this comment

openjdk bot commented Apr 26, 2023 • edited Loading

TheRealMDoerr commented Apr 26, 2023 • edited Loading

bridgekeeper bot commented May 24, 2023

phohensee commented May 24, 2023

bridgekeeper bot commented Jul 13, 2023

shipilev commented Sep 5, 2023

TheRealMDoerr commented Sep 6, 2023 • edited Loading

phohensee commented Sep 6, 2023

phohensee commented Sep 6, 2023

phohensee commented Sep 7, 2023

openjdk bot commented Sep 7, 2023

openjdk bot commented Sep 7, 2023

phohensee commented Jan 17, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Jan 17, 2023 •

edited

Loading

openjdk bot commented Apr 26, 2023 •

edited

Loading

TheRealMDoerr commented Apr 26, 2023 •

edited

Loading

TheRealMDoerr commented Sep 6, 2023 •

edited

Loading