Skip to content

8286562: GCC 12 reports some compiler warnings#1087

Closed
lutkerd wants to merge 1 commit intoopenjdk:masterfrom
lutkerd:8286562
Closed

8286562: GCC 12 reports some compiler warnings#1087
lutkerd wants to merge 1 commit intoopenjdk:masterfrom
lutkerd:8286562

Conversation

@lutkerd
Copy link
Contributor

@lutkerd lutkerd commented Jan 19, 2023

Clean backport to support building with GCC 12, requires 2 followups #1090 to fix tests and #1094 for another issue identified.

Built with GCC 12.2.0 and ran tier1/2 on Linux x64 and aarch64 and no new failures were seen.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1087/head:pull/1087
$ git checkout pull/1087

Update a local copy of the PR:
$ git checkout pull/1087
$ git pull https://git.openjdk.org/jdk17u-dev pull/1087/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1087

View PR using the GUI difftool:
$ git pr show -t 1087

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1087.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 19, 2023

👋 Welcome back lutkerd! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 410a25d59a11b6a627bbb0a2c405c2c2be19f464 8286562: GCC 12 reports some compiler warnings Jan 19, 2023
@openjdk
Copy link

openjdk bot commented Jan 19, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jan 19, 2023
@openjdk
Copy link

openjdk bot commented Jan 19, 2023

⚠️ @lutkerd the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8286562
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Jan 19, 2023

@lutkerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286562: GCC 12 reports some compiler warnings

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 0720b24: 8299497: Usage of constructors of primitive wrapper classes should be avoided in java.desktop API docs
  • a34f2d3: 8300773: Address the inconsistency between the constant array and pool size
  • ba956c5: 8208077: File.listRoots performance degradation
  • 62ccb39: 8295685: Update Libpng to 1.6.38
  • ba023c6: 8297264: C2: Cast node is not processed again in CCP and keeps a wrong too narrow type which is later replaced by top
  • 40b5f15: 8287180: Update IANA Language Subtag Registry to Version 2022-08-08
  • eac9a05: 8292033: Move jdk.X509Certificate event logic to JCA layer
  • 0056a63: 8286705: GCC 12 reports use-after-free potential bugs
  • 68c025b: 8287754: Update jib GNU make dependency on Windows to latest cygwin build
  • 571f5f5: 8300119: CgroupMetrics.getTotalMemorySize0() can report invalid results on 32 bit systems
  • ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/b3e16fc287b6656e0227b30e698f544c3998843d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 19, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 19, 2023

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Jan 20, 2023

Pre-submit tests are failing.
Please fix this first.
Elaborate on testing andn risk in the fix request

@lutkerd
Copy link
Contributor Author

lutkerd commented Jan 20, 2023

Pre-submit tests are failing. Please fix this first. Elaborate on testing andn risk in the fix request

The tests are fixed in a followup #1090 with an additional fix in #1094

@phohensee
Copy link
Member

Commented on and re-tagged the JBS issue.

@lutkerd
Copy link
Contributor Author

lutkerd commented Jan 25, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 25, 2023
@openjdk
Copy link

openjdk bot commented Jan 25, 2023

@lutkerd
Your change (at version f54e17d) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 25, 2023

Going to push as commit 46c1434.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 0720b24: 8299497: Usage of constructors of primitive wrapper classes should be avoided in java.desktop API docs
  • a34f2d3: 8300773: Address the inconsistency between the constant array and pool size
  • ba956c5: 8208077: File.listRoots performance degradation
  • 62ccb39: 8295685: Update Libpng to 1.6.38
  • ba023c6: 8297264: C2: Cast node is not processed again in CCP and keeps a wrong too narrow type which is later replaced by top
  • 40b5f15: 8287180: Update IANA Language Subtag Registry to Version 2022-08-08
  • eac9a05: 8292033: Move jdk.X509Certificate event logic to JCA layer
  • 0056a63: 8286705: GCC 12 reports use-after-free potential bugs
  • 68c025b: 8287754: Update jib GNU make dependency on Windows to latest cygwin build
  • 571f5f5: 8300119: CgroupMetrics.getTotalMemorySize0() can report invalid results on 32 bit systems
  • ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/b3e16fc287b6656e0227b30e698f544c3998843d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 25, 2023
@openjdk openjdk bot closed this Jan 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 25, 2023
@openjdk
Copy link

openjdk bot commented Jan 25, 2023

@phohensee @lutkerd Pushed as commit 46c1434.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants