Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output #109

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jan 20, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/109/head:pull/109
$ git checkout pull/109

Update a local copy of the PR:
$ git checkout pull/109
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/109/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 109

View PR using the GUI difftool:
$ git pr show -t 109

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/109.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 20, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8b5ff4bdffc8f32317d67b00c085071d6c772b30 8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output Jan 20, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 20, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 20, 2022

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

  • 36fc98b: 8273341: Update Siphash to version 1.0
  • 3ca676c: 8269032: Stringdedup tests are failing if the ergonomically select GC does not support it
  • c7329f3: 8186670: Implement _onSpinWait() intrinsic for AArch64
  • 761e298: 8276766: Enable jar and jmod to produce deterministic timestamped content
  • d3eb0a2: 8279998: PPC64 debug builds fail with "untested: RangeCheckStub: predicate_failed_trap_id"
  • f749fc7: 8280002: jmap -histo may leak stream
  • 2137e83: 8277069: [REDO] JDK-8276743 Make openjdk build Zip Archive generation "reproducible"
  • 69d296d: 8279833: Loop optimization issue in String.encodeUTF8_UTF16
  • 6f644e0: 8273277: C2: Move conditional negation into rc_predicate
  • d1d0b08: 8279412: [JVMCI] failed speculations list must outlive any nmethod that refers to it
  • ... and 36 more: https://git.openjdk.java.net/jdk17u-dev/compare/9acabebea76c2fb7de90b2f57917dec2bf0e0507...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jan 20, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 20, 2022

Webrevs

@MBaesken
Copy link
Member Author

@MBaesken MBaesken commented Jan 25, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jan 25, 2022

Going to push as commit 25a418d.
Since your change was applied there have been 115 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jan 25, 2022
@openjdk openjdk bot closed this Jan 25, 2022
@openjdk openjdk bot removed ready rfr labels Jan 25, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 25, 2022

@MBaesken Pushed as commit 25a418d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant