-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8266974: duplicate property key in java.sql.rowset resource bundle #1091
Conversation
Signed-off-by: Shruthi <Shruthi.Shruthi1@ibm.com>
👋 Welcome back shruacha1234! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@shruacha1234 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 120 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
@RealCLanger |
No need to review as it applies clean. Next step would be to ask for fix approval (step 6 of JDK Updates process). I can add the request for you if you give me some input for the Fix request text. |
@RealCLanger These changes remove duplicate property key in java.sql.rowset resource bundle. Tier1 testing shows no issues. The risk is low. |
@RealCLanger Thanks for adding the fix-request tag in the OpenJDK issue |
/integrate |
@shruacha1234 |
/sponsor |
Going to push as commit 9bacd0c.
Your commit was automatically rebased without conflicts. |
@RealCLanger @shruacha1234 Pushed as commit 9bacd0c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Signed-off-by: Shruthi Shruthi.Shruthi1@ibm.com
OpenJDK PR : openjdk/jdk#7212
OpenJDK bug : https://bugs.openjdk.org/browse/JDK-8266974
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1091/head:pull/1091
$ git checkout pull/1091
Update a local copy of the PR:
$ git checkout pull/1091
$ git pull https://git.openjdk.org/jdk17u-dev pull/1091/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1091
View PR using the GUI difftool:
$ git pr show -t 1091
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1091.diff