-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8292033: Move jdk.X509Certificate event logic to JCA layer #1092
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
This backport pull request has now been updated with issue from the original commit. |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit eac9a05.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 17.0.7-oracle.
JCAUtil.java: resolved imports.
X509Factory.java
is moved to cachedGetX509Cert(), and this is edited.
I fixed the corresponding, identical code in engineGenerateCertificate() in
17. I did not find other places in head where the new method is called.
keyword in head.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1092/head:pull/1092
$ git checkout pull/1092
Update a local copy of the PR:
$ git checkout pull/1092
$ git pull https://git.openjdk.org/jdk17u-dev pull/1092/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1092
View PR using the GUI difftool:
$ git pr show -t 1092
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1092.diff