Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292033: Move jdk.X509Certificate event logic to JCA layer #1092

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 20, 2023

I backport this for parity with 17.0.7-oracle.

JCAUtil.java: resolved imports.

X509Factory.java

  • resolved imports
  • in head, engineGenerateCertificate() is refactored. Part of it
    is moved to cachedGetX509Cert(), and this is edited.
    I fixed the corresponding, identical code in engineGenerateCertificate() in
    17. I did not find other places in head where the new method is called.
  • The patch removes commitEvent(). This did not apply because of the 'static'
    keyword in head.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292033: Move jdk.X509Certificate event logic to JCA layer

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1092/head:pull/1092
$ git checkout pull/1092

Update a local copy of the PR:
$ git checkout pull/1092
$ git pull https://git.openjdk.org/jdk17u-dev pull/1092/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1092

View PR using the GUI difftool:
$ git pr show -t 1092

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1092.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 20, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 464e874a5c6b46fcc729227764d07feb1801314d 8048190: NoClassDefFoundError omits original ExceptionInInitializerError Jan 20, 2023
@openjdk
Copy link

openjdk bot commented Jan 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 20, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 20, 2023

Webrevs

@GoeLin GoeLin changed the title 8048190: NoClassDefFoundError omits original ExceptionInInitializerError Backport 102b2b32feec4727145be4814eb1a69ef462ff16 Jan 20, 2023
@openjdk openjdk bot changed the title Backport 102b2b32feec4727145be4814eb1a69ef462ff16 8292033: Move jdk.X509Certificate event logic to JCA layer Jan 20, 2023
@openjdk
Copy link

openjdk bot commented Jan 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 20, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292033: Move jdk.X509Certificate event logic to JCA layer

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 48d5259: 8300490: Spaces in name of MacOS Code Signing Identity are not correctly handled after JDK-8293550

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 20, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Jan 24, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 24, 2023

Going to push as commit eac9a05.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 0056a63: 8286705: GCC 12 reports use-after-free potential bugs
  • 68c025b: 8287754: Update jib GNU make dependency on Windows to latest cygwin build
  • 571f5f5: 8300119: CgroupMetrics.getTotalMemorySize0() can report invalid results on 32 bit systems
  • b7be2bd: 8272985: Reference discovery is confused about atomicity and degree of parallelism
  • 48d5259: 8300490: Spaces in name of MacOS Code Signing Identity are not correctly handled after JDK-8293550

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 24, 2023
@openjdk openjdk bot closed this Jan 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 24, 2023
@openjdk
Copy link

openjdk bot commented Jan 24, 2023

@GoeLin Pushed as commit eac9a05.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8292033 branch January 24, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants