Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8300773: Address the inconsistency between the constant array and pool size #1093

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 20, 2023

This fixes issues in BCEL

I probably hav to do some gymnastics, as 8287916 is closed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8300773: Address the inconsistency between the constant array and pool size

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1093/head:pull/1093
$ git checkout pull/1093

Update a local copy of the PR:
$ git checkout pull/1093
$ git pull https://git.openjdk.org/jdk17u-dev pull/1093/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1093

View PR using the GUI difftool:
$ git pr show -t 1093

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1093.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 20, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 20, 2023

⚠️ @GoeLin the issue with id 8287916 from commit 7b418f9abae9f9f24155a9533b8e80231f49e0c0 does not exist in project JDK.

@GoeLin GoeLin changed the title Backport 7b418f9abae9f9f24155a9533b8e80231f49e0c0 8300773: Address the inconsistency between the constant array and pool size Jan 20, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 20, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 20, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 24, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300773: Address the inconsistency between the constant array and pool size

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 0056a63: 8286705: GCC 12 reports use-after-free potential bugs
  • 68c025b: 8287754: Update jib GNU make dependency on Windows to latest cygwin build
  • 571f5f5: 8300119: CgroupMetrics.getTotalMemorySize0() can report invalid results on 32 bit systems
  • b7be2bd: 8272985: Reference discovery is confused about atomicity and degree of parallelism

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 24, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Jan 25, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 25, 2023

Going to push as commit a34f2d3.
Since your change was applied there have been 9 commits pushed to the master branch:

  • ba956c5: 8208077: File.listRoots performance degradation
  • 62ccb39: 8295685: Update Libpng to 1.6.38
  • ba023c6: 8297264: C2: Cast node is not processed again in CCP and keeps a wrong too narrow type which is later replaced by top
  • 40b5f15: 8287180: Update IANA Language Subtag Registry to Version 2022-08-08
  • eac9a05: 8292033: Move jdk.X509Certificate event logic to JCA layer
  • 0056a63: 8286705: GCC 12 reports use-after-free potential bugs
  • 68c025b: 8287754: Update jib GNU make dependency on Windows to latest cygwin build
  • 571f5f5: 8300119: CgroupMetrics.getTotalMemorySize0() can report invalid results on 32 bit systems
  • b7be2bd: 8272985: Reference discovery is confused about atomicity and degree of parallelism

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 25, 2023
@openjdk openjdk bot closed this Jan 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 25, 2023
@openjdk
Copy link

openjdk bot commented Jan 25, 2023

@GoeLin Pushed as commit a34f2d3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8287916 branch January 25, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants