Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion #1095

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jan 22, 2023

Hi all,
This pull request contains a backport of commit abeddab9 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 24 Nov 2022 and was reviewed by Jayathirth D V and Damon Nguyen.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1095/head:pull/1095
$ git checkout pull/1095

Update a local copy of the PR:
$ git checkout pull/1095
$ git pull https://git.openjdk.org/jdk17u-dev pull/1095/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1095

View PR using the GUI difftool:
$ git pr show -t 1095

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1095.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 22, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport abeddab991d71f4ea54665082ffcb284267d7f44 6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion Jan 22, 2023
@openjdk
Copy link

openjdk bot commented Jan 22, 2023

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review January 22, 2023 18:01
@openjdk
Copy link

openjdk bot commented Jan 22, 2023

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 22, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 22, 2023

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Jan 23, 2023

What is wrong with the pre-submit tests?
Removing tags in the meantime, please tag again.

@mrserb
Copy link
Member Author

mrserb commented Jan 24, 2023

What is wrong with the pre-submit tests? Removing tags in the meantime, please tag again.

The unrelated unstable test fails: https://bugs.openjdk.org/browse/JDK-8294705

These tests reported failure:

java/util/DoubleStreamSums/CompensatedSums

@mrserb
Copy link
Member Author

mrserb commented Jan 25, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 25, 2023

Going to push as commit b3a8ad5.
Since your change was applied there have been 13 commits pushed to the master branch:

  • b3e305e: 8294705: Disable an assertion in test/jdk/java/util/DoubleStreamSums/CompensatedSums.java
  • 46c1434: 8286562: GCC 12 reports some compiler warnings
  • 0720b24: 8299497: Usage of constructors of primitive wrapper classes should be avoided in java.desktop API docs
  • a34f2d3: 8300773: Address the inconsistency between the constant array and pool size
  • ba956c5: 8208077: File.listRoots performance degradation
  • 62ccb39: 8295685: Update Libpng to 1.6.38
  • ba023c6: 8297264: C2: Cast node is not processed again in CCP and keeps a wrong too narrow type which is later replaced by top
  • 40b5f15: 8287180: Update IANA Language Subtag Registry to Version 2022-08-08
  • eac9a05: 8292033: Move jdk.X509Certificate event logic to JCA layer
  • 0056a63: 8286705: GCC 12 reports use-after-free potential bugs
  • ... and 3 more: https://git.openjdk.org/jdk17u-dev/compare/48d525946da6c34383c674a73961d6a46acb3fd6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 25, 2023
@openjdk openjdk bot closed this Jan 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 25, 2023
@openjdk
Copy link

openjdk bot commented Jan 25, 2023

@mrserb Pushed as commit b3a8ad5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants