-
Notifications
You must be signed in to change notification settings - Fork 224
8251216: Implement MD5 intrinsics on AArch64 #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back dchuyko! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@dchuyko This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 137 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
It'd be a good idea to configure pre-submit testing. |
/integrate |
/sponsor |
Going to push as commit 49cf332.
Your commit was automatically rebased without conflicts. |
@phohensee @dchuyko Pushed as commit 49cf332. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
As mentioned in the original review MD5 can't be considered a secure hash. But it is still widely used as a lightweight generic hash function, and that's true not only for a legacy software. It is in fact not as lightweight as expected, e.g. hardware accelerated SHA-1 and SHA-256 work much faster on N1. We can sweeten the pill at least for the latest LTS release by 25-30% acceleration with this change.
Original patch applies almost cleanly. There was a minor fuzz, and "code_size2 = 45000" increase had to be re-applied manually.
Micro-benchmark results in openjdk.bench.javax.crypto.full.MessageDigestBench on Graviton 2 show improvements identical to original numbers on Altra.
Testing: tier1, tier2, test/hotspot/jtreg/compiler/intrinsics/sha (aarch64)
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/110/head:pull/110
$ git checkout pull/110
Update a local copy of the PR:
$ git checkout pull/110
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/110/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 110
View PR using the GUI difftool:
$ git pr show -t 110
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/110.diff