Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251216: Implement MD5 intrinsics on AArch64 #110

Closed
wants to merge 1 commit into from

Conversation

dchuyko
Copy link
Member

@dchuyko dchuyko commented Jan 20, 2022

As mentioned in the original review MD5 can't be considered a secure hash. But it is still widely used as a lightweight generic hash function, and that's true not only for a legacy software. It is in fact not as lightweight as expected, e.g. hardware accelerated SHA-1 and SHA-256 work much faster on N1. We can sweeten the pill at least for the latest LTS release by 25-30% acceleration with this change.

Original patch applies almost cleanly. There was a minor fuzz, and "code_size2 = 45000" increase had to be re-applied manually.

Micro-benchmark results in openjdk.bench.javax.crypto.full.MessageDigestBench on Graviton 2 show improvements identical to original numbers on Altra.

Testing: tier1, tier2, test/hotspot/jtreg/compiler/intrinsics/sha (aarch64)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/110/head:pull/110
$ git checkout pull/110

Update a local copy of the PR:
$ git checkout pull/110
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/110/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 110

View PR using the GUI difftool:
$ git pr show -t 110

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/110.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 20, 2022

👋 Welcome back dchuyko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 088b244ec6d9393a1fcd2233fa5b4cf46f9ae0dd 8251216: Implement MD5 intrinsics on AArch64 Jan 20, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 20, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Jan 20, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 20, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Lgtm.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 20, 2022

@dchuyko This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8251216: Implement MD5 intrinsics on AArch64

Reviewed-by: phh, luhenry

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 137 new commits pushed to the master branch:

  • a93e5ef: 8275608: runtime/Metaspace/elastic/TestMetaspaceAllocationMT2 too slow
  • 096c31c: 8276057: Update JMH devkit to 1.33
  • 0cc9d30: 8275082: Update XML Security for Java to 2.3.0
  • 3d6f331: 8177814: jdk/editpad is not in jdk TEST.groups
  • 0a1419c: 8253197: vmTestbase/nsk/jvmti/StopThread/stopthrd007/TestDescription.java fails with "ERROR: DebuggeeSleepingThread: ThreadDeath lost"
  • 59d39ef: 8236505: Mark jdk/editpad/EditPadTest.java as @headful
  • 28dcaf3: 8272553: several hotspot runtime/CommandLine tests don't check exit code
  • 6315ce3: 8275687: runtime/CommandLine/PrintTouchedMethods test shouldn't catch RuntimeException
  • 25a418d: 8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output
  • 55fb592: 8273972: Multi-core choke point in CMM engine (LCMSTransform.doTransform)
  • ... and 127 more: https://git.openjdk.java.net/jdk17u-dev/compare/dcd98215f257f4e373dd58e0daf0013be2c53850...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jan 20, 2022
@phohensee
Copy link
Member

@phohensee phohensee commented Jan 25, 2022

It'd be a good idea to configure pre-submit testing.

@dchuyko
Copy link
Member Author

@dchuyko dchuyko commented Jan 26, 2022

/integrate

@openjdk openjdk bot added the sponsor label Jan 26, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 26, 2022

@dchuyko
Your change (at version c8233c4) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

@phohensee phohensee commented Jan 26, 2022

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jan 26, 2022

Going to push as commit 49cf332.
Since your change was applied there have been 138 commits pushed to the master branch:

  • 9378f26: 8278241: Implement JVM SpinPause on linux-aarch64
  • a93e5ef: 8275608: runtime/Metaspace/elastic/TestMetaspaceAllocationMT2 too slow
  • 096c31c: 8276057: Update JMH devkit to 1.33
  • 0cc9d30: 8275082: Update XML Security for Java to 2.3.0
  • 3d6f331: 8177814: jdk/editpad is not in jdk TEST.groups
  • 0a1419c: 8253197: vmTestbase/nsk/jvmti/StopThread/stopthrd007/TestDescription.java fails with "ERROR: DebuggeeSleepingThread: ThreadDeath lost"
  • 59d39ef: 8236505: Mark jdk/editpad/EditPadTest.java as @headful
  • 28dcaf3: 8272553: several hotspot runtime/CommandLine tests don't check exit code
  • 6315ce3: 8275687: runtime/CommandLine/PrintTouchedMethods test shouldn't catch RuntimeException
  • 25a418d: 8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output
  • ... and 128 more: https://git.openjdk.java.net/jdk17u-dev/compare/dcd98215f257f4e373dd58e0daf0013be2c53850...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jan 26, 2022
@openjdk openjdk bot closed this Jan 26, 2022
@openjdk openjdk bot removed ready rfr sponsor labels Jan 26, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 26, 2022

@phohensee @dchuyko Pushed as commit 49cf332.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
3 participants