-
Notifications
You must be signed in to change notification settings - Fork 223
8277990: NMT: Remove NMT shutdown capability #1116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewed-by: stuefe, shade
👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
Windows GHA issues unrelated; SAP nightlies are error-free |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tstuefe This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
GHA errors on Windows unrelated. Nightlies at SAP are clean. /integrate |
Going to push as commit 9a992ab.
Your commit was automatically rebased without conflicts. |
This removes the NMT shutdown machinery from hotspot. For details, please see the associated JBS issue, as well as the companion change https://bugs.openjdk.org/browse/JDK-8277946 and CSR https://bugs.openjdk.org/browse/JDK-8277947.
This is not a clean backport, but the fixes are very minor:
Testing:
I manually ran runtime/NMT and all gtest variants for NMT on linux x64 and x86.
SAP nightlies are scheduled.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1116/head:pull/1116
$ git checkout pull/1116
Update a local copy of the PR:
$ git checkout pull/1116
$ git pull https://git.openjdk.org/jdk17u-dev pull/1116/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1116
View PR using the GUI difftool:
$ git pr show -t 1116
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1116.diff