Skip to content

8277990: NMT: Remove NMT shutdown capability #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Jan 26, 2023

This removes the NMT shutdown machinery from hotspot. For details, please see the associated JBS issue, as well as the companion change https://bugs.openjdk.org/browse/JDK-8277946 and CSR https://bugs.openjdk.org/browse/JDK-8277947.

This is not a clean backport, but the fixes are very minor:

  • the original patch changes perfmemory_posix.cpp, but this hunk is not needed in JDK17
  • A small fix was needed since the "shutdown" dcmd option in JDK17 had been deprecated out of carefulness, not outright removed: 5ce36d6 .

Testing:
I manually ran runtime/NMT and all gtest variants for NMT on linux x64 and x86.
SAP nightlies are scheduled.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1116/head:pull/1116
$ git checkout pull/1116

Update a local copy of the PR:
$ git checkout pull/1116
$ git pull https://git.openjdk.org/jdk17u-dev pull/1116/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1116

View PR using the GUI difftool:
$ git pr show -t 1116

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1116.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 26, 2023

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5a036ace01ebedd88fb3d9100e3a0c19871677ac 8277990: NMT: Remove NMT shutdown capability Jan 26, 2023
@openjdk
Copy link

openjdk bot commented Jan 26, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 26, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 26, 2023

Webrevs

@tstuefe
Copy link
Member Author

tstuefe commented Jan 28, 2023

Windows GHA issues unrelated; SAP nightlies are error-free

Copy link
Member

@MBaesken MBaesken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Jan 30, 2023

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277990: NMT: Remove NMT shutdown capability

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 4a9bd23: 8275704: Metaspace::contains() should be threadsafe
  • b22bce8: 8276086: Increase size of metaspace mappings
  • 1a38e26: 8297963: Partially fix string expansion issues in UTIL_DEFUN_NAMED and related macros
  • 4e5f5de: 8192931: Regression test java/awt/font/TextLayout/CombiningPerf.java fails
  • 5fd778b: 8300692: GCC 12 reports some compiler warnings in bundled freetype
  • 651ba86: 8286694: Incorrect argument processing in java launcher
  • f6ad61c: 8275582: Don't purge metaspace mapping lists
  • b7d83f4: 8293466: libjsig should ignore non-modifying sigaction calls
  • fae1628: 8293493: Signal Handlers printout should show signal block state

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 30, 2023
@tstuefe
Copy link
Member Author

tstuefe commented Jan 31, 2023

GHA errors on Windows unrelated. Nightlies at SAP are clean.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 31, 2023

Going to push as commit 9a992ab.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 7b39d48: 8298129: Let checkpoint event sizes grow beyond u4 limit
  • 0e98d6a: 8301397: [11u, 17u] Bump jtreg to fix issue with build JDK 11.0.18
  • 201ceb7: 8280007: Enable Neoverse N1 optimizations for Arm Neoverse V1 & N2
  • 7fa6bc2: 8294160: misc crash dump improvements
  • a7c0ed1: 8230374: maxOutputSize, instead of javatest.maxOutputSize, should be used in TEST.properties
  • 9fc178b: 8285965: TestScenarios.java does not check for "" correctly
  • d37977e: 8286873: Improve websocket test execution time
  • 4be1ed4: 8284115: [IR Framework] Compilation is not found due to rare safepoint while dumping PrintIdeal/PrintOptoAssembly
  • 4a9bd23: 8275704: Metaspace::contains() should be threadsafe
  • b22bce8: 8276086: Increase size of metaspace mappings
  • ... and 7 more: https://git.openjdk.org/jdk17u-dev/compare/d1ad5962502519a24e5fc3945a493ae3a8e41d74...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 31, 2023
@openjdk openjdk bot closed this Jan 31, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 31, 2023
@openjdk
Copy link

openjdk bot commented Jan 31, 2023

@tstuefe Pushed as commit 9a992ab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants