Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286694: Incorrect argument processing in java launcher #1117

Closed
wants to merge 1 commit into from

Conversation

lutkerd
Copy link
Contributor

@lutkerd lutkerd commented Jan 26, 2023

Backport of another fix for GCC 12 support. Build and tier1/2 are passing locally with required patches on linux x64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8286694: Incorrect argument processing in java launcher

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1117/head:pull/1117
$ git checkout pull/1117

Update a local copy of the PR:
$ git checkout pull/1117
$ git pull https://git.openjdk.org/jdk17u-dev pull/1117/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1117

View PR using the GUI difftool:
$ git pr show -t 1117

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1117.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 26, 2023

👋 Welcome back lutkerd! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 26c7c92bc93f3eecf7ce69c69f1999ba879d1d60 8286694: Incorrect argument processing in java launcher Jan 26, 2023
@openjdk
Copy link

openjdk bot commented Jan 26, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jan 26, 2023
@lutkerd lutkerd marked this pull request as ready for review January 26, 2023 19:07
@openjdk openjdk bot added the clean label Jan 26, 2023
@openjdk
Copy link

openjdk bot commented Jan 26, 2023

@lutkerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286694: Incorrect argument processing in java launcher

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • f6ad61c: 8275582: Don't purge metaspace mapping lists
  • b7d83f4: 8293466: libjsig should ignore non-modifying sigaction calls
  • fae1628: 8293493: Signal Handlers printout should show signal block state
  • d1ad596: 8293691: converting a defined BasicType value to a string should not crash the VM

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 26, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 26, 2023

Webrevs

@lutkerd
Copy link
Contributor Author

lutkerd commented Jan 26, 2023

Windows presubmit failures are the ongoing issue with failures building JTreg.

@lutkerd
Copy link
Contributor Author

lutkerd commented Jan 27, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 27, 2023
@openjdk
Copy link

openjdk bot commented Jan 27, 2023

@lutkerd
Your change (at version ee11c6e) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 27, 2023

Going to push as commit 651ba86.
Since your change was applied there have been 4 commits pushed to the master branch:

  • f6ad61c: 8275582: Don't purge metaspace mapping lists
  • b7d83f4: 8293466: libjsig should ignore non-modifying sigaction calls
  • fae1628: 8293493: Signal Handlers printout should show signal block state
  • d1ad596: 8293691: converting a defined BasicType value to a string should not crash the VM

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 27, 2023
@openjdk openjdk bot closed this Jan 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 27, 2023
@openjdk
Copy link

openjdk bot commented Jan 27, 2023

@phohensee @lutkerd Pushed as commit 651ba86.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants