8299296: Write a test to verify the components selection sends ItemEvent#1131
8299296: Write a test to verify the components selection sends ItemEvent#1131Rudometov wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@Rudometov This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
Changes are only in test/jdk/java/awt/event/ComponentEvent/ComponentItemEventTest.java file. Failures in github actions are not related to this new test. F.e.: Windows builds failures: CLASSPATH="D:/a/jdk17u-dev/jdk17u-dev/jtreg/src/build/classes;D:/a/jdk17u-dev/jdk17u-dev/jtreg/src/build/deps/jtharness/build/binaries/lib/javatest.jar" |
|
/integrate |
|
@Rudometov |
|
/sponsor |
|
Going to push as commit fe770e3.
Your commit was automatically rebased without conflicts. |
|
@phohensee @Rudometov Pushed as commit fe770e3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of https://bugs.openjdk.org/browse/JDK-8299296
Clean backport.
Parity with 17.0.8-oracle.
Low risk, new test.
Test passes on linux and macOS
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1131/head:pull/1131$ git checkout pull/1131Update a local copy of the PR:
$ git checkout pull/1131$ git pull https://git.openjdk.org/jdk17u-dev pull/1131/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1131View PR using the GUI difftool:
$ git pr show -t 1131Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1131.diff