Skip to content

8299296: Write a test to verify the components selection sends ItemEvent#1131

Closed
Rudometov wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:Rudometov-backport-5ae6de85
Closed

8299296: Write a test to verify the components selection sends ItemEvent#1131
Rudometov wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:Rudometov-backport-5ae6de85

Conversation

@Rudometov
Copy link
Member

@Rudometov Rudometov commented Jan 31, 2023

Backport of https://bugs.openjdk.org/browse/JDK-8299296

Clean backport.
Parity with 17.0.8-oracle.
Low risk, new test.
Test passes on linux and macOS


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299296: Write a test to verify the components selection sends ItemEvent

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1131/head:pull/1131
$ git checkout pull/1131

Update a local copy of the PR:
$ git checkout pull/1131
$ git pull https://git.openjdk.org/jdk17u-dev pull/1131/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1131

View PR using the GUI difftool:
$ git pr show -t 1131

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1131.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 31, 2023

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5ae6de859d472d107cdf642c417c6d2f1c74e5db 8299296: Write a test to verify the components selection sends ItemEvent Jan 31, 2023
@openjdk
Copy link

openjdk bot commented Jan 31, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jan 31, 2023
@openjdk
Copy link

openjdk bot commented Jan 31, 2023

@Rudometov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299296: Write a test to verify the components selection sends ItemEvent

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 38eb0d6: 8293326: jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java slow on Windows
  • 012a216: 8289400: Improve com/sun/jdi/TestScaffold error reporting
  • c74eb2b: 8292066: Convert TestInputArgument.sh and TestSystemLoadAvg.sh to java version
  • 78c6be2: 8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases
  • 50c3433: 8291825: java/time/nontestng/java/time/zone/CustomZoneNameTest.java fails if defaultLocale and defaultFormatLocale are different
  • a3f2288: 8286844: com/sun/jdi/RedefineCrossEvent.java failed with 1 threads completed while VM suspended
  • 7224cbe: 8287593: ShortResponseBody could be made more resilient to rogue connections
  • 83c0805: 8289948: Improve test coverage for XPath functions: Node Set Functions
  • b9e4d10: 8289440: Remove vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded003 from ProblemList.txt
  • c9fac0e: 8282036: Change java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions
  • ... and 8 more: https://git.openjdk.org/jdk17u-dev/compare/201ceb705489be031e483864c6808a7aae3f9644...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 31, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 31, 2023

Webrevs

@Rudometov
Copy link
Member Author

Rudometov commented Jan 31, 2023

Changes are only in test/jdk/java/awt/event/ComponentEvent/ComponentItemEventTest.java file.

Failures in github actions are not related to this new test.

F.e.:
macOS builds failures:
CLASSPATH="/Users/runner/work/jdk17u-dev/jdk17u-dev/jtreg/src/build/classes:/Users/runner/work/jdk17u-dev/jdk17u-dev/jtreg/src/make/../build/deps/jtharness/build/binaries/lib/javatest.jar"
/Users/runner/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.18-10/x64/Contents/Home//bin/javac -source 1.2 -target 1.1 -Xlint:all,-options,-deprecation, -Werror
-d /Users/runner/work/jdk17u-dev/jdk17u-dev/jtreg/src/build/classes
-encoding ISO8859-1
../src/share/classes/com/sun/javatest/regtest/agent/AppletWrapper.java ../src/share/classes/com/sun/javatest/regtest/agent/GetSystemProperty.java ../src/share/classes/com/sun/javatest/regtest/agent/MainWrapper.java ../src/share/classes/com/sun/javatest/regtest/agent/AStatus.java ../src/share/classes/com/sun/javatest/regtest/agent/StringArray.java
error: Source option 1.2 is no longer supported. Use 6 or later.
error: Target option 1.1 is no longer supported. Use 1.6 or later.
make: *** [/Users/runner/work/jdk17u-dev/jdk17u-dev/jtreg/src/build/classes.com.sun.javatest.regtest-othervm.ok] Error 2

Windows builds failures:

CLASSPATH="D:/a/jdk17u-dev/jdk17u-dev/jtreg/src/build/classes;D:/a/jdk17u-dev/jdk17u-dev/jtreg/src/build/deps/jtharness/build/binaries/lib/javatest.jar"
C:/hostedtoolcache/windows/Java_Temurin-Hotspot_jdk/11.0.18-10/x64/bin/javac -source 1.2 -target 1.1 -Xlint:all,-options,-deprecation, -Werror
-d D:/a/jdk17u-dev/jdk17u-dev/jtreg/src/build/classes
-encoding ISO8859-1
../src/share/classes/com/sun/javatest/regtest/agent/AppletWrapper.java ../src/share/classes/com/sun/javatest/regtest/agent/GetSystemProperty.java ../src/share/classes/com/sun/javatest/regtest/agent/MainWrapper.java ../src/share/classes/com/sun/javatest/regtest/agent/AStatus.java ../src/share/classes/com/sun/javatest/regtest/agent/StringArray.java
error: Source option 1.2 is no longer supported. Use 6 or later.
error: Target option 1.1 is no longer supported. Use 1.6 or later.
make: *** [jtreg.gmk:41: D:/a/jdk17u-dev/jdk17u-dev/jtreg/src/build/classes.com.sun.javatest.regtest-othervm.ok] Error 2

@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 3, 2023
@openjdk
Copy link

openjdk bot commented Feb 3, 2023

@Rudometov
Your change (at version d410c55) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 3, 2023

Going to push as commit fe770e3.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 38eb0d6: 8293326: jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java slow on Windows
  • 012a216: 8289400: Improve com/sun/jdi/TestScaffold error reporting
  • c74eb2b: 8292066: Convert TestInputArgument.sh and TestSystemLoadAvg.sh to java version
  • 78c6be2: 8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases
  • 50c3433: 8291825: java/time/nontestng/java/time/zone/CustomZoneNameTest.java fails if defaultLocale and defaultFormatLocale are different
  • a3f2288: 8286844: com/sun/jdi/RedefineCrossEvent.java failed with 1 threads completed while VM suspended
  • 7224cbe: 8287593: ShortResponseBody could be made more resilient to rogue connections
  • 83c0805: 8289948: Improve test coverage for XPath functions: Node Set Functions
  • b9e4d10: 8289440: Remove vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded003 from ProblemList.txt
  • c9fac0e: 8282036: Change java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions
  • ... and 8 more: https://git.openjdk.org/jdk17u-dev/compare/201ceb705489be031e483864c6808a7aae3f9644...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 3, 2023
@openjdk openjdk bot closed this Feb 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 3, 2023
@openjdk
Copy link

openjdk bot commented Feb 3, 2023

@phohensee @Rudometov Pushed as commit fe770e3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants