8296329: jar validator doesn't account for minor class file version

[rvansa]

Technically not clean, changed Java versions in test (separate commit)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8296329: jar validator doesn't account for minor class file version

Reviewers

• Yuri Nesterenko (@yan-too - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1132/head:pull/1132
$ git checkout pull/1132

Update a local copy of the PR:
$ git checkout pull/1132
$ git pull https://git.openjdk.org/jdk17u-dev pull/1132/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1132

View PR using the GUI difftool:
$ git pr show -t 1132

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1132.diff

[bridgekeeper]

👋 Welcome back rvansa! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (0baa4682)
• 01: Full - Incremental (aeb7adf3)
• 00: Full (0baa4682)

[openjdk]

@rvansa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

@rvansa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296329: jar validator doesn't account for minor class file version

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 83c0805: 8289948: Improve test coverage for XPath functions: Node Set Functions
• b9e4d10: 8289440: Remove vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded003 from ProblemList.txt
• c9fac0e: 8282036: Change java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions
• 535c64b: 8209935: Test to cover CodeSource.getCodeSigners()
• 62461a2: 8271838: AmazonCA.java interop test fails
• 71f53ad: 8286154: Fix 3rd party notices in test files
• 49a0287: 6779701: Wrong defect ID in the code of test LocalRMIServerSocketFactoryTest.java
• 501a4bf: 8298649: JFR: RemoteRecordingStream support for checkpoint event sizes beyond u4

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[rvansa]

/integrate

[openjdk]

@rvansa
Your change (at version 0baa468) is now ready to be sponsored by a Committer.

[yan-too]

integrate is too early here, let's wait for maintainer's jdk17u-fix-yes

[yan-too]

/sponsor

[openjdk]

Going to push as commit 4ab869e.
Since your change was applied there have been 20 commits pushed to the master branch:

• ceabaee: 8300590: [JVMCI] BytecodeFrame.equals is broken
• ddd9631: 8294677: chunklevel::MAX_CHUNK_WORD_SIZE too small for some applications
• 0ed3689: 8299194: CustomTzIDCheckDST.java may fail at future date
• 2fa09bb: 8290836: Improve test coverage for XPath functions: String Functions
• fe770e3: 8299296: Write a test to verify the components selection sends ItemEvent
• 38eb0d6: 8293326: jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java slow on Windows
• 012a216: 8289400: Improve com/sun/jdi/TestScaffold error reporting
• c74eb2b: 8292066: Convert TestInputArgument.sh and TestSystemLoadAvg.sh to java version
• 78c6be2: 8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases
• 50c3433: 8291825: java/time/nontestng/java/time/zone/CustomZoneNameTest.java fails if defaultLocale and defaultFormatLocale are different
• ... and 10 more: https://git.openjdk.org/jdk17u-dev/compare/9a992abfdb29fda57d0b8d97dab38ee95bb600b5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@yan-too @rvansa Pushed as commit 4ab869e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.