Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases #1136

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 31, 2023

I backport this for parity with 17.0.7-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1136/head:pull/1136
$ git checkout pull/1136

Update a local copy of the PR:
$ git checkout pull/1136
$ git pull https://git.openjdk.org/jdk17u-dev pull/1136/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1136

View PR using the GUI difftool:
$ git pr show -t 1136

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1136.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 31, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e8bc87956abc92851de8694c56a78f6ecc546cbd 8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases Jan 31, 2023
@openjdk
Copy link

openjdk bot commented Jan 31, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 31, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 31, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 31, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Feb 2, 2023

Pre-submit failure: For target jdk_modules_java.management.rmi__the.java.management.rmi_batch:
IOException caught during compilation: Connection reset
Infra, unrelated.

@GoeLin
Copy link
Member Author

GoeLin commented Feb 2, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 2, 2023

Going to push as commit 78c6be2.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 50c3433: 8291825: java/time/nontestng/java/time/zone/CustomZoneNameTest.java fails if defaultLocale and defaultFormatLocale are different
  • a3f2288: 8286844: com/sun/jdi/RedefineCrossEvent.java failed with 1 threads completed while VM suspended
  • 7224cbe: 8287593: ShortResponseBody could be made more resilient to rogue connections
  • 83c0805: 8289948: Improve test coverage for XPath functions: Node Set Functions
  • b9e4d10: 8289440: Remove vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded003 from ProblemList.txt
  • c9fac0e: 8282036: Change java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions
  • 535c64b: 8209935: Test to cover CodeSource.getCodeSigners()
  • 62461a2: 8271838: AmazonCA.java interop test fails
  • 71f53ad: 8286154: Fix 3rd party notices in test files
  • 49a0287: 6779701: Wrong defect ID in the code of test LocalRMIServerSocketFactoryTest.java

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 2, 2023
@openjdk openjdk bot closed this Feb 2, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 2, 2023
@openjdk
Copy link

openjdk bot commented Feb 2, 2023

@GoeLin Pushed as commit 78c6be2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant